[stable22] Correctly skip suppressed errors in PHP 8.0 #27938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan12125
changed the title
juliushaertl
requested review from
ChristophWurst,
nickvergessen,
juliushaertl and
blizzz
juliushaertl
approved these changes
Jul 13, 2021
|
Hmm, integration tests on branch stable22 seem broken after #27654 |
|
Revert of #27654 merged, so a rebase should fix ;) |
Applies the suggested transformation mentioned in https://www.php.net/manual/en/migration80.incompatible.php, > The @ operator will no longer silence fatal errors (E_ERROR, > E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR, > E_PARSE). Error handlers that expect error_reporting to be 0 when > @ is used, should be adjusted to use a mask check instead The new code still works on PHP 7, as error_reporting() already returns 0 when diagnostics are suppressed. This fixes #25807 in PHP 8.0. For PHP 7.x, #22243 suppresses the E_NOTICE message from the second session_start() call with the error suppression operator @, and thus those E_NOTICE messages are still logged in PHP 8.0. See also #25806 Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
|
Thanks, it is green now :) |
blizzz
approved these changes
Jul 14, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #27631
Applies the suggested transformation mentioned in
https://www.php.net/manual/en/migration80.incompatible.php,
The new code still works on PHP 7, as error_reporting() already
returns 0 when diagnostics are suppressed.
This fixes #25807 in PHP 8.0.
For PHP 7.x, #22243 suppresses
the E_NOTICE message from the second session_start() call with the error
suppression operator @, and thus those E_NOTICE messages are still
logged in PHP 8.0.
See also #25806
Signed-off-by: Chih-Hsuan Yen yan12125@gmail.com