-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose additional emails in {DAV:}alternate-URI-set #31029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
added
enhancement
3. to review
Waiting for reviews
feature: dav
feature: caldav
Related to CalDAV internals
labels
Feb 5, 2022
tcitworld
requested review from
icewind1991,
ChristophWurst,
juliusknorr and
miaulalala
February 5, 2022 19:15
tcitworld
commented
Feb 5, 2022
tcitworld
force-pushed
the
expose-extra-emails-in-dav
branch
from
February 5, 2022 19:24
3c67295
to
e672feb
Compare
tcitworld
force-pushed
the
expose-extra-emails-in-dav
branch
from
February 15, 2022 09:17
e672feb
to
910c815
Compare
Merged
Merged
tcitworld
force-pushed
the
expose-extra-emails-in-dav
branch
from
March 31, 2022 07:47
910c815
to
45284cc
Compare
tcitworld
force-pushed
the
expose-extra-emails-in-dav
branch
2 times, most recently
from
May 12, 2022 16:04
fdfaf81
to
b79b689
Compare
Can someone restart Drone? |
Could try a no-edit force push?
|
tcitworld
force-pushed
the
expose-extra-emails-in-dav
branch
from
May 16, 2022 20:42
b79b689
to
733368f
Compare
This allows iMip invitations to be send with an alternative email as "Reply-To" field. Closes #27201 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
expose-extra-emails-in-dav
branch
from
May 17, 2022 13:11
733368f
to
190a71e
Compare
ChristophWurst
approved these changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
PVince81
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
feature: caldav
Related to CalDAV internals
feature: dav
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows iMip invitations to be send with an alternative email as "Reply-To" field.
The emails are provided in the
alternate-URI-set
prop, and throughcalendar-user-address-set
andemail-address-set
on a CalDAV principal.https://github.com/nextcloud/3rdparty/blob/41d5f9752c7e0f2b690480a38ef5b9dddc357166/sabre/dav/lib/CalDAV/Plugin.php#L347-L367
However, it's not possible to find users principals from their alternative emails by filtering through
{http://sabredav.org/ns}email-address
orcalendar-user-address-set
(which only use the system email address).server/apps/dav/lib/Connector/Sabre/Principal.php
Lines 299 to 311 in 9c2db7f
Closes #27201