Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional emails in {DAV:}alternate-URI-set #31029

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

tcitworld
Copy link
Member

This allows iMip invitations to be send with an alternative email as "Reply-To" field.

The emails are provided in the alternate-URI-set prop, and through calendar-user-address-set and email-address-set on a CalDAV principal.

https://github.com/nextcloud/3rdparty/blob/41d5f9752c7e0f2b690480a38ef5b9dddc357166/sabre/dav/lib/CalDAV/Plugin.php#L347-L367

However, it's not possible to find users principals from their alternative emails by filtering through {http://sabredav.org/ns}email-address or calendar-user-address-set (which only use the system email address).

case '{http://sabredav.org/ns}email-address':
if (!$allowEnumeration) {
if ($allowEnumerationFullMatch) {
$users = $this->userManager->getByEmail($value);
} else {
$users = [];
}
} else {
$users = $this->userManager->getByEmail($value);
$users = \array_filter($users, function (IUser $user) use ($currentUser, $value, $limitEnumerationPhone, $limitEnumerationGroup, $allowEnumerationFullMatch, $currentUserGroups) {
if ($allowEnumerationFullMatch && $user->getSystemEMailAddress() === $value) {
return true;
}

Closes #27201

@tcitworld
Copy link
Member Author

Can someone restart Drone?

@Pytal
Copy link
Member

Pytal commented May 16, 2022

Can someone restart Drone?

Could try a no-edit force push?

git commit --amend --no-edit
git push --force

This allows iMip invitations to be send with an alternative email as
"Reply-To" field.

Closes #27201

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: caldav Related to CalDAV internals feature: dav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Thunderbird calendar reply address when creating invitations, not the nextcloud email user email address
5 participants