Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit missing primary key fail to new tables and comment out for now #31580

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Limit missing primary key fail to new tables and comment out for now #31580

merged 2 commits into from
Mar 22, 2022

Conversation

nickvergessen
Copy link
Member

This will work on CI so devs notice it when they install the app for testing,
and at the same time existing faulty tables don't break the upgrade to 24

Regression from #31513

@nickvergessen nickvergessen requested review from PVince81, ChristophWurst, CarlSchwan, a team and ArtificialOwl and removed request for a team March 15, 2022 15:54
@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Mar 15, 2022
@nickvergessen nickvergessen mentioned this pull request Mar 16, 2022
Closed
@nickvergessen nickvergessen changed the title Limit missing primary key fail to new tables Limit missing primary key fail to new tables and comment out for now Mar 16, 2022
@nickvergessen
Copy link
Member Author

Reasons to disable for now:

  • occ db:add-missing-primarykeys can't fix it before the upgrade is run
  • e2ee fails
  • circles fails

@nickvergessen
Copy link
Member Author

cc @PVince81 lets disable for now

PVince81
PVince81 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen
Limit missing primary key fail to new tables
32ede54 
This will work on CI so devs notice it when they install the app for testing,
and at the same time existing faulty tables don't break the upgrade to 24

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Disable for now again until more apps are fixed
3bed983 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Rebased as the PR was broken after Carl rebased when github had issues last week

@PVince81 PVince81 merged commit acfa546 into master Mar 22, 2022
@PVince81 PVince81 deleted the nickvergessen-patch-2 branch March 22, 2022 09:58
@come-nc
Copy link
Contributor

come-nc commented Mar 22, 2022

@nickvergessen This broke the CI, the nodb drone step won’t pass:

There was 1 failure:

1) Test\DB\MigrationsTest::testEnsureOracleConstraintsNoPrimaryKey
Failed asserting that exception of type "InvalidArgumentException" is thrown.

nickvergessen added a commit that referenced this pull request Mar 22, 2022
@nickvergessen
Test disabled for now due to multiple reasons
89e293d 
see #31580 (comment) for details

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Mar 22, 2022
Merged
@nickvergessen nickvergessen mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: install and update regression
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @come-nc @PVince81 @ChristophWurst