-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sidebar not automatically hidden in Files app #35052
Fix sidebar not automatically hidden in Files app #35052
Conversation
/backport to stable25 |
/backport to stable24 |
/backport to stable23 |
3rdparty change should not be here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking due to unintended 3rdparty bump
Although the Files app creates the legacy sidebar (details view) it is then replaced with the newer Vue app sidebar. Due to this ".detailsView" no longer finds an element and therefore nothing was hidden when "hideAppSidebar($('.detailsView'))" was called (for example, when changing to another section). However, "OC.Apps.hideAppSidebar()" does not properly work either with the Vue sidebar used in the Files app (once hidden the sidebar is not shown again). For simplicity, and to avoid any possible side effect in other apps from changing "OC.Apps.hideAppSidebar", now "OC.Files.Sidebar.close()" is used instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
bb799d3
to
a8fea27
Compare
Ugh 🤦 Sorry, fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it fixes #33848 :)
Fixes #33848
This might be happening since #15719 (but I have not verified it)
Although the Files app creates the legacy sidebar (details view) it is then replaced with the newer Vue app sidebar. Due to this
.detailsView
no longer finds an element and therefore nothing was hidden whenhideAppSidebar($('.detailsView'))
was called (for example, when changing to another section).However,
OC.Apps.hideAppSidebar()
does not properly work either with the Vue sidebar used in the Files app (once hidden the sidebar is not shown again). For simplicity, and to avoid any possible side effect in other apps from changingOC.Apps.hideAppSidebar
, nowOC.Files.Sidebar.close()
is used instead.How to test
Result with this pull request
The sidebar is hidden
Result without this pull request
The sidebar is not hidden