Fix array to string conversion in errorlog writer #35614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
changed the title
This was referenced Dec 5, 2022
|
Possibly a duplicate of #34256 |
|
I'm the author of issue #35589. I've downloaded this pull request as .patch file and I've applied it to my nextcloud environment, it fixed the issue. |
ChristophWurst
added
3. to review
ChristophWurst
requested review from
nickvergessen,
wolframroesler,
danxuliu,
ecblack,
pixelipo and
BernhardPosselt
|
/backport to stable25 |
|
/backport to stable24 |
come-nc
approved these changes
Dec 19, 2022
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/errorlog-array-to-string-conversion
branch
from
d1c4e4c
to
58a0740
Compare
artonge
approved these changes
Dec 19, 2022
|
@ChristophWurst backports? |
1 task
|
/backport to stable24 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #35589
Summary
#8946 changed log messages from
stringtostring|arraybut not for the interface and all possible implementations. All loggers still worked except the errorlog one.TODO
Checklist