[F2V] migrate files_trashbin to vue #36534

skjnldsv · 2023-02-04T11:37:46Z

Needs:

Follow-up:

Improve loading indicator for actions
Deepen virtual scrolling performances
Implement keyboard arrow/pageUp-Down navigation and focus management
Hide some columns on small screens

apps/files_trashbin/lib/Controller/PreviewController.php

@@ -118,7 +119,7 @@
 				$mimeType = $this->mimeTypeDetector->detectPath($file->getName());
 			}

-			$f = $this->previewManager->getPreview($file, $x, $y, true, IPreview::MODE_FILL, $mimeType);
+			$f = $this->previewManager->getPreview($file, $x, $y, $a, IPreview::MODE_FILL, $mimeType);


apps/files/lib/Controller/ApiController.php

-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'file_sorting_direction', $direction);
-		return new Response();
+
+		$userId = $this->userSession->getUser()->getUID();


apps/files/lib/Controller/ApiController.php

apps/comments/src/services/DavClient.js

apps/comments/src/services/GetComments.ts

apps/comments/src/views/Comments.vue

apps/files/js/app.js

apps/files/js/filelist.js

apps/files/src/components/CustomElementRender.vue

apps/files/src/components/FilesListHeader.vue

apps/files/src/views/FilesList.vue

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

juliusknorr · 2023-04-06T14:20:01Z

Looks very nice already :) Just some findings, could also be follow ups

Switching back to other file list does not work once entered the trash bin once
Previews show a black box
Restore/delete permanently a file does not remove it from the list
Grid view is gone
Breadcrumbs show Foldername.dTIMESTAMP when browsing a deleted folder, in the old implementation we just showed `Foldername
Sorting by size/name doesn't work yet

skjnldsv · 2023-04-06T14:30:37Z

Previews show a black box

You mean when it's loading? Because I do see previews :)

Restore/delete permanently a file does not remove it from the list

It used to... 🤦
I'll investigate in followup

Breadcrumbs show Foldername.dTIMESTAMP when browsing a deleted folder, in the old implementation we just showed `Foldername

Yeah, I need to see how I can mitigate this without performance drawback :)

Sorting by size/name doesn't work yet

Works here! 🤔

Peek.06-04-2023.16-29.mp4

The rest of your points will be followups 😉

szaimen · 2023-04-06T14:41:30Z

Additionally to Julius' findings, I also found something:

right-click does not work anymore
the mobile view is currently completely broken (but already in the top post as I can see)
clicking on a file in the trashbin downloads the file but with incorrect mimetype ending
there is at least one warning in the console log when I open the trashbin:

Apart from that looks good to me!

skjnldsv · 2023-04-06T14:45:24Z

@szaimen self signed certificate?
Service workers cannot be loaded on self signed, this is a browser issue.

clicking on a file in the trashbin downloads the file but with incorrect mimetype ending

Can you clarify what do oyou mean with the ending? The extention?
If so this is an issue with the dav backend 😉 (while we could mitigate with the front)
Will open a ticket afterwards 👍

szaimen · 2023-04-06T14:46:45Z

ending? The extention?

yes I mean the extension.

Downloaded files look like this for example:

szaimen · 2023-04-06T14:47:17Z

@szaimen self signed certificate?
Service workers cannot be loaded on self signed, this is a browser issue.

Ah I see. Then this is probably a no-issue.

szaimen · 2023-04-06T14:49:12Z

BTW is there already some chunking implemented so that only a few files are loaded and then only when scrolling further down? (I have not tested this)...

juliusknorr · 2023-04-06T15:00:12Z

Previews show a black box

You mean when it's loading? Because I do see previews :)

Still doesn't after retesting. I have the following console trace, that looks related:

PreviewService.ts:30 Uncaught (in promise) ReferenceError: caches is not defined
    at isCachedPreview (PreviewService.ts:30:1)
    at _callee$ (FileEntry.vue?vue&type=script&lang=ts&:269:1)
    at tryCatch (core-common.js:223538:40)
    at Generator.invoke (core-common.js:223773:22)
    at Generator.next (core-common.js:223598:21)
    at asyncGeneratorStep (FileEntry.vue?vue&type=script&lang=ts&:2:1)
    at _next (FileEntry.vue?vue&type=script&lang=ts&:3:1)
    at FileEntry.vue?vue&type=script&lang=ts&:3:1
    at new Promise (<anonymous>)
    at FileEntry.vue?vue&type=script&lang=ts&:3:1

Sorting by size/name doesn't work yet

Works here! 🤔

Interesting, retested and works now.

apps/files/src/services/PreviewService.ts

skjnldsv added enhancement 2. developing Work in progress technical debt labels Feb 4, 2023

skjnldsv added this to the Nextcloud 27 milestone Feb 4, 2023

skjnldsv self-assigned this Feb 4, 2023

skjnldsv force-pushed the feat/files2vue-trashbin branch from e8a7830 to e51912a Compare February 4, 2023 20:27

github-advanced-security bot found potential problems Feb 5, 2023

View reviewed changes

skjnldsv force-pushed the feat/files2vue-trashbin branch 3 times, most recently from c640275 to ce90a9a Compare March 24, 2023 16:17

github-advanced-security bot found potential problems Mar 24, 2023

View reviewed changes

skjnldsv force-pushed the feat/files2vue-trashbin branch 3 times, most recently from cf4797b to ae3fd22 Compare March 28, 2023 15:37

skjnldsv force-pushed the feat/files2vue-trashbin branch 2 times, most recently from 1b76d46 to 47d53c7 Compare April 5, 2023 06:42

skjnldsv requested review from a team, artonge, Pytal and szaimen and removed request for a team April 5, 2023 07:17

skjnldsv added 3. to review Waiting for reviews feature: files feature: trashbin and removed 2. developing Work in progress labels Apr 5, 2023

come-nc reviewed Apr 5, 2023

View reviewed changes

apps/files/lib/Controller/ApiController.php Show resolved Hide resolved

skjnldsv mentioned this pull request Apr 5, 2023

Bump @nextcloud/vue to version "^7.9.0" #37586

Merged

4 tasks

artonge reviewed Apr 5, 2023

View reviewed changes

skjnldsv force-pushed the feat/files2vue-trashbin branch from 63dbb65 to 427b33a Compare April 5, 2023 15:47

skjnldsv added 4 commits April 6, 2023 15:31

chore(eslint): clean and fix

1361182

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(tests): update jsunit tests after dep and files update

f060e5a

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(cypress): component testing with pinia

d432e0c

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix:(files-checker): add cypress.d.ts and custom.d.ts

8298bb4

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

skjnldsv force-pushed the feat/files2vue-trashbin branch from cd7404a to 9be777b Compare April 6, 2023 13:32

skjnldsv added 2 commits April 6, 2023 15:43

fix(files): better wording and catch single action run

ea3e77d

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(tests): acceptance

5b3900e

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

skjnldsv force-pushed the feat/files2vue-trashbin branch from 9be777b to 5b3900e Compare April 6, 2023 13:43

skjnldsv requested a review from artonge April 6, 2023 13:46

juliusknorr reviewed Apr 6, 2023

View reviewed changes

apps/files/src/services/PreviewService.ts Show resolved Hide resolved

skjnldsv merged commit 2e6e154 into master Apr 6, 2023

skjnldsv deleted the feat/files2vue-trashbin branch April 6, 2023 15:05

szaimen mentioned this pull request Apr 6, 2023

follow-up to files_trashbin to vue migration #37627

Closed

11 tasks

This was referenced Apr 7, 2023

Trashbin followup fixes #37633

Merged

feat(files): responsive design for mobile and narrow screens #37642

Merged

feat(files): right click #37669

Merged

ChristophWurst mentioned this pull request May 12, 2023

[Bug]: [ERROR] files: SW registration failed: NS_ERROR_CONTENT_BLOCKED #38219

Closed

9 tasks

AsamK mentioned this pull request Jun 24, 2023

[Bug]: Regression in apps using data-apps-slide-toggle for settings toggle button #38981

Closed

8 tasks

joshtrichards mentioned this pull request Jul 8, 2023

Download deleted file #14439

Closed

Pytal mentioned this pull request Jul 20, 2023

fix(a11y): Files table roles #39385

Closed

4 tasks

joshtrichards mentioned this pull request Aug 14, 2023

[Bug]: Content Security Policy (CSP) Error for preview-service-worker.js #39849

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[F2V] migrate files_trashbin to vue #36534

[F2V] migrate files_trashbin to vue #36534

skjnldsv commented Feb 4, 2023 •

edited

Loading

juliusknorr commented Apr 6, 2023 •

edited by szaimen

Loading

skjnldsv commented Apr 6, 2023 •

edited

Loading

szaimen commented Apr 6, 2023

skjnldsv commented Apr 6, 2023

szaimen commented Apr 6, 2023

szaimen commented Apr 6, 2023

szaimen commented Apr 6, 2023

juliusknorr commented Apr 6, 2023

[F2V] migrate files_trashbin to vue #36534

[F2V] migrate files_trashbin to vue #36534

Conversation

skjnldsv commented Feb 4, 2023 • edited Loading

Needs:

Follow-up:

juliusknorr commented Apr 6, 2023 • edited by szaimen Loading

skjnldsv commented Apr 6, 2023 • edited Loading

szaimen commented Apr 6, 2023

skjnldsv commented Apr 6, 2023

szaimen commented Apr 6, 2023

szaimen commented Apr 6, 2023

szaimen commented Apr 6, 2023

juliusknorr commented Apr 6, 2023

skjnldsv commented Feb 4, 2023 •

edited

Loading

juliusknorr commented Apr 6, 2023 •

edited by szaimen

Loading

skjnldsv commented Apr 6, 2023 •

edited

Loading