Add social sharing #3679

rullzer · 2017-03-02T13:20:46Z

Add socialshare manager
Add social share field under link share

Fixes #3368 based on owncloud/core#25576

Basically it introduces a manager (in javascript) to add the social sharing buttons. This makes sure that people that don't want social sharing or want their own fancy social network can just write their own app.

Edit: this is how it looks now:

To see it in action install https://github.com/nextcloud/socialsharingdefault

As usualy some CSS wizzard to make it look better is appreciated else we do it like this until somebodies eyes bleed enough. @nextcloud/designers

ChristophWurst · 2017-03-02T13:37:31Z

core/js/sharedialoglinksocialview.js

+		showLink: true,
+
+		events: {
+			"click .pop-up": 'onPopUpClick'


mixed quotes

ChristophWurst · 2017-03-02T13:39:30Z

core/js/sharedialoglinksocialview.js

+	});
+
+	OC.Share.ShareDialogLinkSocialView = ShareDialogLinkSocialView;
+})();


I think it would make sense to pass OC and any other globals as parameter here.

I agree in general. But I don't wanna mess with the init stuff there right now.

ChristophWurst · 2017-03-02T13:40:28Z

core/js/sharedialogview.js

@@ -421,6 +426,9 @@
 			this.shareeListView.$el = this.$el.find('.shareeListView');
 			this.shareeListView.render();

+			this.socialView.$el = this.$el.find('.socialView');


this.$('.socialView') would be simpler

ChristophWurst · 2017-03-02T13:41:18Z

core/js/sharedialogview.js

@@ -69,6 +70,9 @@
 		/** @type {object} **/
 		shareeListView: undefined,

+		/** @type {object} **/


OC.Share.ShareDialogLinkSocialView?

jancborchardt · 2017-03-02T16:39:25Z

Design-wise, instead of just dumping it down there as buttons (as another product does …), we should properly integrate it.

For that we simply create a menu where the »Copy link« button was. It serves as the so-to-say »Link sharing« options, of which copying is a part as much as sharing to other services:

cc @nextcloud/designers

rullzer · 2017-03-03T08:07:54Z

@jancborchardt that looks better indeed. Let me see what I can come up with!

* Add socialshare manager * Add social share field under link share Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

* If there are social sharing buttons move them and the copy action to a menu * If there are no social sharing buttons just leave the copy action where it is directly Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer · 2017-03-03T12:38:48Z

@jancborchardt now looks like

Somebody that actually knows CSS has to make it look nice. But it is in the menu.
When there are no social sharing plugins it is just the same as before.

tcitworld · 2017-03-03T12:46:08Z

Is the « Share to » part really necessary ? Isn't a line split into the three icons side by side (fb/g+/twitter) enough ?

Spartachetto · 2017-03-03T14:43:23Z

Some proposals/suggestions, up to you to evaluate if interesting

if the mail client is present, it could be useful to have the option Share via mail
It would be cool to extend the supported social networks, especially with the decentralized ones (diaspora*, GNU social, ...)
I am wondering if in some contexts (e.g.: a private firm Nextcloud installation) could be required to block the sharing via social media, or to allow only some of them (I know that @jancborchardt loves options 😄 )

rullzer · 2017-03-06T07:59:55Z

@tcitworld I don't care. Somebody with more artistic talent than me has to fix that. Maybe I just make it super ugly so somebody has to fix it before the release ;)

rullzer · 2017-03-06T08:01:34Z

@Spartachetto The buttons are provided by an app. So people can write an app for any social media or other thing they want. For example if you only want to allow your users to share to instagram you have to (pay somebody to) write a simple app and only enable that.

oparoz · 2017-03-06T14:31:23Z

I'm a bit worried about the very low discoverability of the feature when it' hidden behind the 3 dots.
@jancborchardt Please conduct a few usability tests to validate that it's obvious enough.

schiessle · 2017-03-06T14:56:34Z

It would be cool to extend the supported social networks, especially with the decentralized ones

I agree, we should have at least one network which fits our philosophy, so I added Diaspora for now: nextcloud/socialsharing#1 (because it was easy, we use it already in the personal settings to share your federated cloud id)

schiessle · 2017-03-06T16:13:15Z

I'm a bit worried about the very low discoverability of the feature when it' hidden behind the 3 dots.

I think in general this is fine. But I agree that it is hard to discover it for the first time. Imho that's a nice example why a "what's new" notification makes a lot of sense :hides:

rullzer · 2017-03-06T20:23:18Z

@schiessle no I won't add that to the default app. Because people are going to be whining that they want to get rid of it. We can write a different app for diaspora (I just combined g+, fb and twitter because people that want social sharing will for 99% want those).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

MariusBluem · 2017-03-06T20:44:01Z

I agree with @rullzer, but I think it is already in now 😕 See nextcloud/socialsharing#1

rullzer · 2017-03-06T20:50:48Z

Ah well. What is done is done

schiessle · 2017-03-06T20:51:19Z

@rullzer I strongly disagree. 99% also use Dropbox, GDrive or icloud. That's not an argument. I would argue that in our community you have a lot Diaspora users and people who strongly disagree with Facebook, G+, Twitter & Co. By presenting only this options we send the wrong signal.

MorrisJobke · 2017-03-06T20:53:01Z

@rullzer I strongly disagree. 99% also use Dropbox, GDrive or icloud. That's not an argument. I would argue that in our community you have a lot Diaspora users and people who strongly disagree with Facebook, G+, Twitter & Co. By presenting only this options we send the wrong signal.

Sadly I need to disagree and we will get a change request to remove diaspora from a customer for sure ...

schiessle · 2017-03-06T20:58:05Z

Sadly I need to disagree and we will get a change request to remove diaspora from a customer for sure ...

We will see. I expect most customer will remove it completely and will not be disturbed by just one specific social network. How much customers requested to remove Diaspora from the "share my federated cloud ID"?

tcitworld · 2017-03-06T21:17:35Z

We can write a different app for diaspora (I just combined g+, fb and twitter because people that want social sharing will for 99% want those).

Couldn't we just add an admin settings section to activate/deactivate some of the social shares possibilities ?

EDIT : My idea is to support more than 3 default social share methods with the socialsharingdefault app, like D*, instagram, linkedin, with only fb/twitter/g+ activated. I feel it stupid to have maybe 5 more apps that do nothing more than adding share buttons. And such sharing provider apps would never get updated anyway.
If a share method is really exotic, then let's provide another app.

MariusBluem · 2017-03-06T21:29:33Z

Google+, Facebook and Twitter have some kind of the same target group ... Diaspora is however is outstanding - it should be in a separate provider. This is why the social sharing implementation stuff is done via providers - we can split up this into several provider apps.

Especially enterprise users will usually not use diaspora - and may be irritated by this icon 😅 I have to agree!

@schiessle See the upsides of doing this. With doing this, admins can also go the diaspora-only way, and disable Google+, Twitter and Facebook 😉 Everybody wins.

rullzer · 2017-03-07T07:48:35Z

So the app is just an example (because I needed more than 1 there). The approach will be basically 1 app per provider. So everybody can create their own social sharing list. This IMO makes a lot more sense then 1 app that holds everything and then we spend time developing a new admin interface to enable certain parts.

jancborchardt · 2017-03-08T13:15:52Z

An admin should have one single setting, and that is »enable sharing to social networks«. Then users should have individual settings to enable/disable the individual networks, whichever they use. This is not an admin decision because different users use different networks. Hence it makes no sense as different apps.

oparoz · 2017-03-08T13:31:16Z

Then users should have individual settings to enable/disable the individual networks, whichever they use. This is not an admin decision because different users use different networks.

Yes and we should cap it at 3 or 5 networks to make it manageable in the sharing interface

Hence it makes no sense as different apps.

Actually, it makes total sense. If one app becomes unmaintained or has security issues, it's easy to disable/remove.
We should provide an app skeleton and a naming convention (easy discovery) and I'm sure the community would be keen to release new SocialSharing apps.

The alternative is to have some form of plugin system. Could be "Dump a class here" system since admins would be responsible for enabling the network, but I foresee some serious upgrade issues.

jancborchardt · 2017-03-08T14:06:28Z

That’s all fine tech-wise, as long as in a default install of Nextcloud:

You (as admin) don’t need to initially enable a whole bunch of apps for the most basic networks such as Facebook and Twitter (those are even default on iOS for example, we could even make the enabled ones language-dependent like Weibo in China)
You (as user) can share to social networks via the dropdown in »share link« (possible to disable for the admin)
You (as user) can disable individual social networks in your personal settings

@rullzer is that possible with this approach?

rullzer · 2017-03-08T14:10:29Z

@jancborchardt No. and very much out of scope for now

oparoz · 2017-03-08T14:18:13Z

the most basic networks such as Facebook and Twitter (those are even default on iOS for example

Don't forget that these are not the default by accident. The companies behind the products pay millions for the product placement.

Spartachetto · 2017-03-12T15:30:04Z

First of all, thank to all of you that "made it happen" with your coding!

I am just citing my experience as one of the possible scenarios.
In my experience there are some work related contexts that see some of the social networks as "professional" and some others as "for fun".
I do not want to say that this is right or wrong, yet it happened to me to work in a place in which there was a strong push to use Twitter (and Linkedin), yet Facebook was seen as "unprofessional".
From my experience that was even true between the peers not working in the firm.

So in that professional context the "usual three" were not usual except one.

schiessle · 2017-03-14T17:06:35Z

@rullzer: We should consider adding a "share by mail" option. What do you think? This would also make people here happy: #2357 😉

rullzer · 2017-03-14T18:15:38Z

@schiessle uhm sure, not that hard 😄

MorrisJobke · 2017-03-15T04:52:01Z

I fixed the layout and it now looks like this:

Can we please get this one here get in? This is only the base and has nothing to do with how the providers are hooked in (apps vs sharing setting) and which ones.

👍 from me

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

ChristophWurst · 2017-07-15T05:43:09Z

i dunno if i'm in the correct thread to post my problems with socialsharing, especially facebook. so if not please feel free to move this post to the correct thread.

Please use the GitHub search to check whether this has been reported at https://github.com/nextcloud/server/issues and if not, please file an issue at https://github.com/nextcloud/server/issues/new. Thanks!

rullzer added 3. to review Waiting for reviews enhancement feature: sharing labels Mar 2, 2017

rullzer added this to the Nextcloud 12.0 milestone Mar 2, 2017

rullzer requested review from nickvergessen and MorrisJobke March 2, 2017 13:20

rullzer mentioned this pull request Mar 2, 2017

Share to social networks #3368

Closed

ChristophWurst reviewed Mar 2, 2017

View reviewed changes

rullzer force-pushed the socialsharing branch from 1a60c56 to da7a148 Compare March 2, 2017 14:40

jancborchardt added the design Design, UI, UX, etc. label Mar 2, 2017

Add social sharing

a85327f

* Add socialshare manager * Add social share field under link share Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

nickvergessen removed their request for review March 3, 2017 11:10

rullzer added 2 commits March 3, 2017 13:27

Move social buttons to menu

fd71b8b

* If there are social sharing buttons move them and the copy action to a menu * If there are no social sharing buttons just leave the copy action where it is directly Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Make sure copy tooltip remains when we have no social providers

835b49d

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer force-pushed the socialsharing branch from da7a148 to 835b49d Compare March 3, 2017 12:36

schiessle mentioned this pull request Mar 6, 2017

add diaspora nextcloud/socialsharing#1

Merged

Fix tests

be45d6a

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

MariusBluem mentioned this pull request Mar 7, 2017

Reconsider app name and a nice icon nextcloud/socialsharing#2

Closed

MorrisJobke approved these changes Mar 15, 2017

View reviewed changes

Fix layout of sharing buttons

13aae43

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

MorrisJobke force-pushed the socialsharing branch from 66fc6a3 to 13aae43 Compare March 15, 2017 04:52

LukasReschke approved these changes Mar 16, 2017

View reviewed changes

LukasReschke merged commit 39afcbd into master Mar 16, 2017

LukasReschke deleted the socialsharing branch March 16, 2017 22:08

MorrisJobke mentioned this pull request May 1, 2017

Fix "Copied" message for public links #4638

Merged

Add social sharing #3679

Add social sharing #3679

Conversation

rullzer commented Mar 2, 2017 • edited by MorrisJobke Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jancborchardt commented Mar 2, 2017

rullzer commented Mar 3, 2017

rullzer commented Mar 3, 2017

tcitworld commented Mar 3, 2017 • edited Loading

Spartachetto commented Mar 3, 2017

rullzer commented Mar 6, 2017

rullzer commented Mar 6, 2017

oparoz commented Mar 6, 2017

schiessle commented Mar 6, 2017 • edited Loading

schiessle commented Mar 6, 2017

rullzer commented Mar 6, 2017

MariusBluem commented Mar 6, 2017

rullzer commented Mar 6, 2017

schiessle commented Mar 6, 2017

MorrisJobke commented Mar 6, 2017

schiessle commented Mar 6, 2017

tcitworld commented Mar 6, 2017 • edited Loading

MariusBluem commented Mar 6, 2017 • edited Loading

rullzer commented Mar 7, 2017

jancborchardt commented Mar 8, 2017

oparoz commented Mar 8, 2017

jancborchardt commented Mar 8, 2017

rullzer commented Mar 8, 2017

oparoz commented Mar 8, 2017 • edited Loading

Spartachetto commented Mar 12, 2017

schiessle commented Mar 14, 2017

rullzer commented Mar 14, 2017

MorrisJobke commented Mar 15, 2017

ChristophWurst commented Jul 15, 2017

rullzer commented Mar 2, 2017 •

edited by MorrisJobke

Loading

tcitworld commented Mar 3, 2017 •

edited

Loading

schiessle commented Mar 6, 2017 •

edited

Loading

tcitworld commented Mar 6, 2017 •

edited

Loading

MariusBluem commented Mar 6, 2017 •

edited

Loading

oparoz commented Mar 8, 2017 •

edited

Loading