Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar optimizations #39568

Merged
merged 2 commits into from Aug 14, 2023
Merged

Calendar optimizations #39568

merged 2 commits into from Aug 14, 2023

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jul 25, 2023

  • preload shares for calendars when listing calendars
  • cache calendar objects when doing calendarQuery

These save N queries when listing calendars and when listing calendar objects respectively.

apps/dav/lib/DAV/Sharing/Backend.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/CalDavBackend.php Fixed Show fixed Hide fixed
apps/dav/lib/DAV/Sharing/Backend.php Fixed Show fixed Hide fixed
@icewind1991 icewind1991 changed the title preload shares for calendars when listing calendars Calendar optimizations Jul 26, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice.

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change 👍

@kesselb kesselb added the 3. to review Waiting for reviews label Aug 2, 2023
@icewind1991 icewind1991 merged commit 30e9f52 into master Aug 14, 2023
41 checks passed
@icewind1991 icewind1991 deleted the caldav-share-preload branch August 14, 2023 08:27
@icewind1991
Copy link
Member Author

/backport to stable27

@icewind1991
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@icewind1991
Copy link
Member Author

26: #39861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants