Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace inaccessible disabled option of NcCheckboxRadioSwitch with NcNoteCard #43015

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Replace inaccessible disabled option of NcCheckboxRadioSwitch with NcNoteCard #43015

merged 2 commits into from
Jan 23, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 22, 2024 •
edited by susnux
Loading

Replace inaccessible disabled option of NcCheckboxRadioSwitch with NcNoteCard

Summary

🖼️ Screenshots

🏚️ Before 🏡 After
image Screenshot from 2024-01-22 11-33-24

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jan 22, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 22, 2024
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/42941-Replace_samtically_incorrect_elements_on_Artificial_Intelligence_setting_page branch from f9fe94c to 419f4f7 Compare January 22, 2024 10:34
szaimen
szaimen approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Jan 22, 2024 •
edited
Loading

/compile /

@emoral435
Copy link
Contributor

emoral435 commented Jan 22, 2024 •
edited
Loading

/backport aa8f76d to stable28

@JuliaKirschenheuter @emoral435
fix(files): replace inaccessible disabled option of NcCheckboxRadioSw…
aa8f76d 
…itch with NcNoteCard

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@nextcloud-command @emoral435
chore(assets): Recompile assets
60df95f 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@emoral435 emoral435 force-pushed the fix/42941-Replace_samtically_incorrect_elements_on_Artificial_Intelligence_setting_page branch from 5f0a7aa to 60df95f Compare January 22, 2024 19:31
@susnux susnux added this to the Nextcloud 29 milestone Jan 22, 2024
@JuliaKirschenheuter JuliaKirschenheuter merged commit 4bf4cee into master Jan 23, 2024
44 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/42941-Replace_samtically_incorrect_elements_on_Artificial_Intelligence_setting_page branch January 23, 2024 08:02
@backportbot backportbot bot mentioned this pull request Jan 23, 2024
Merged
1 task
@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2024
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen szaimen approved these changes

@emoral435 emoral435 emoral435 approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
6 participants
@JuliaKirschenheuter @emoral435 @ShGKme @szaimen @susnux @nextcloud-command