-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf): add cache for authtoken lookup #43057
Conversation
eb6cd37
to
2a649b2
Compare
2a649b2
to
07112b8
Compare
07112b8
to
e7555f9
Compare
e7555f9
to
d1b3490
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & works
Blackfire confirms that 2 requests are shaved off most requests.
Loading my dev env dashboard causes 18 auth token SELECTs on master and 1 here.
🚀
fd3b086
to
9ebd2e4
Compare
9ebd2e4
to
5e684f2
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
5e684f2
to
d1189f9
Compare
Any chance this could be backported? |
/backport to stable28 |
/backport to stable27 |
/backport to stable26 |
The backport to # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b backport/43057/stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d1189f92
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43057/stable26 Error: Failed to push branch backport/43057/stable26: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Add cache for
authtoken
lookupChecklist