Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): add cache for authtoken lookup #43057

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Jan 23, 2024

Summary

Add cache for authtoken lookup

Checklist

@Altahrim Altahrim self-assigned this Jan 23, 2024
@Altahrim Altahrim force-pushed the feat/cache-authtoken branch 2 times, most recently from eb6cd37 to 2a649b2 Compare January 24, 2024 08:46
@Altahrim Altahrim requested review from ChristophWurst, a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team January 25, 2024 15:55
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 25, 2024
@Altahrim Altahrim marked this pull request as ready for review January 25, 2024 15:55
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

Blackfire confirms that 2 requests are shaved off most requests.
Loading my dev env dashboard causes 18 auth token SELECTs on master and 1 here.

🚀

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 25, 2024
@Altahrim Altahrim force-pushed the feat/cache-authtoken branch 2 times, most recently from fd3b086 to 9ebd2e4 Compare February 28, 2024 09:50
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 28, 2024
@skjnldsv skjnldsv merged commit e0705f1 into master Mar 1, 2024
160 checks passed
@skjnldsv skjnldsv deleted the feat/cache-authtoken branch March 1, 2024 13:47
@blizzz blizzz mentioned this pull request Mar 5, 2024
@solracsf
Copy link
Member

Any chance this could be backported?

@Altahrim Altahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Mar 25, 2024
@Altahrim
Copy link
Collaborator Author

/backport to stable28

@Altahrim
Copy link
Collaborator Author

/backport to stable27

@Altahrim
Copy link
Collaborator Author

/backport to stable26

Copy link

backportbot bot commented Mar 25, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/43057/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d1189f92

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43057/stable26

Error: Failed to push branch backport/43057/stable26: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@joshtrichards joshtrichards added this to the Nextcloud 29 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cache authtoken lookup by token
5 participants