New emails for sharebymail

[MorrisJobke]

• I added a new method to allow adding a single button with no width constraints
• escape the texts of the heading, body and button text with htmlspecialchars (is this enough, @LukasReschke ) - this was needed to show also file names in there and not cause code injection (the escaping is only done in the HTML emails and not in the text emails
• migrate share email and the password notification email

[mention-bot]

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @jancborchardt and @LukasReschke to be potential reviewers.

[MorrisJobke]

Followup to #4304 and #4244

[MorrisJobke]

Before:

After:

[MorrisJobke]

@nextcloud/designers I'm also open for new wordings of the emails, because it's a lot of duplicate text. Maybe you have better ideas. cc @Espina2

[rullzer]

Awesome stuff. Lets do this!

[LukasReschke]

Rebased upon master.

[schiessle]

The HTML mail looks awesome! But the text mail looks strange:

admin shared »welcome.txt« with you

admin shared »welcome.txt« with you. Click the button below to open it.

Open »welcome.txt«: http://localhost/master/index.php/s/RPGlwrxTJr2lrm5
--
Nextcloud - a safe home for all your data
This is an automatically generated email, please do not reply.

Can we fix this?

[nickvergessen]

i will fix

[LukasReschke]

escape the texts of the heading, body and button text with htmlspecialchars (is this enough, @LukasReschke ) - this was needed to show also file names in there and not cause code injection (the escaping is only done in the HTML emails and not in the text emails

Not entirely sure about that. For example in the activity app we would have an email that uses something like:

$emailTemplate->addBodyText($l->t('There was some activity at %s', [$this->urlGenerator->getAbsoluteURL('/')]));

In this case having HTML allowed here for URLs (and a separate text for plain text) may be very useful. Also I think sometimes some stuff like <strong> may be useful as well. Thoughts?

[LukasReschke]

Also HTML may be useful when embedding icons like the activity state icons. Just a thought though :-)

[schiessle]

I fixed the footer for the plain text mails.

The plain text mail looks now better, also with the changes by @nickvergessen :

Although I think the "Click the button below to open it." still sounds a bit strange for a plain-text mail. I think the best would be to create two separate templates. This way we can make sure that we have a useful text in both cases and that we have reasonable line breaks, which is not a issue here but maybe with other mails (something <= 80 chars).

[nickvergessen]

@schiessle addBodyText has two parameters, just make use of it.

[Espina2]

I think you can more information like that. @MorrisJobke

[enoch85]

@Espina2 Just plain perfection.

[schiessle]

@nickvergessen I saw it. The "problem" is that we then have to split it up in two "addBodyText()" calls which will result in a line break, right? ... but I will try.

[schiessle]

As expected it looks rather ugly on the html mail if it put in in two "addBodyText()" calls because of the line breaks:

[nickvergessen]

Not sure what you did, but I made two little commits and it looks good

[codecov-io]

Codecov Report

Merging #4307 into master will decrease coverage by 16.34%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #4307       +/-   ##
=============================================
- Coverage     54.03%   37.68%   -16.35%     
+ Complexity    21417    21407       -10     
=============================================
  Files          1321     1317        -4     
  Lines         81696    81630       -66     
  Branches       1305     1305               
=============================================
- Hits          44147    30765    -13382     
- Misses        37549    50865    +13316

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Mail/EMailTemplate.php	0% <0%> (-76.06%)	30 <8> (+5)
apps/sharebymail/lib/ShareByMailProvider.php	60.94% <0%> (+0.47%)	62 <0> (-3)	⬇️
core/Command/TwoFactorAuth/Enable.php	0% <0%> (-100%)	4% <0%> (ø)
...factor_backupcodes/lib/Activity/GenericSetting.php	0% <0%> (-100%)	8% <0%> (ø)
apps/files/lib/Activity/Settings/FileChanged.php	0% <0%> (-100%)	8% <0%> (ø)
apps/dav/lib/CalDAV/Plugin.php	0% <0%> (-100%)	2% <0%> (ø)
lib/private/Files/SimpleFS/SimpleFolder.php	0% <0%> (-100%)	11% <0%> (ø)
lib/private/Files/SimpleFS/SimpleFile.php	0% <0%> (-100%)	9% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Todo.php	0% <0%> (-100%)	8% <0%> (ø)
...ofactor_backupcodes/lib/Activity/GenericFilter.php	0% <0%> (-100%)	7% <0%> (ø)
... and 449 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dccb892...983210d. Read the comment docs.

[MorrisJobke]

Tested and works nice 👍

[MorrisJobke]

@Espina2 Looks nice, but something for a followup. First of all we should get rid of the super ugly way. ;) See #4334

[MorrisJobke]

When you update stuff like this, then you should also update the unit tests. Let me do this.

[MorrisJobke]

I fixed the unit tests. Looks good now from my side 👍