Cache path by id #43471
Merged
Cache path by id #43471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
cache-path-by-id
branch
from
2e8fb89
to
e7108d5
Compare
icewind1991
force-pushed
the
cache-path-by-id
branch
2 times, most recently
from
ed9cc7d
to
a2846be
Compare
icewind1991
force-pushed
the
cache-path-by-id
branch
3 times, most recently
from
6baf20a
to
57e7266
Compare
icewind1991
force-pushed
the
cache-path-by-id
branch
2 times, most recently
from
0a36121
to
68ad797
Compare
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
nfebe
and removed request for
a team
icewind1991
force-pushed
the
cache-path-by-id
branch
from
2f8b275
to
82b8696
Compare
come-nc
reviewed
Feb 19, 2024
skjnldsv
added
2. developing
icewind1991
force-pushed
the
cache-path-by-id
branch
from
82b8696
to
3ed8287
Compare
icewind1991
force-pushed
the
cache-path-by-id
branch
2 times, most recently
from
dbb9170
to
3dfef53
Compare
…des for the id this should be enough in most(?) cases and makes efficient implementation and caching easier Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
cache-path-by-id
branch
from
3dfef53
to
5d55e1a
Compare
…rstNodeById Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
cache-path-by-id
branch
from
5d55e1a
to
a9ee278
Compare
icewind1991
added
3. to review
Altahrim
approved these changes
Mar 5, 2024
Merged
9 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache fileid to path mapping.
The fact that a single fileid can have multiple paths complicates attampts to cache this information, however since most usages of
getByIdonly use a single item of the result, and always the same one (whether or not this is correct for that usage is another question 🙈). We can provide a new api that only returns a single result which makes caching easier.We can get away with using a local cache without doing any active cache invalidation by checking that the node at the path we cached still has the correct fileid.
getFirstNodeByIdto get a single node for id regardless of how many nodes with that id the user hasgetByIdthat always use the first node to the new apigetFirstNodeByIdI would recommend reviewing this PR commit-by-commit as most of the changes by LOC are mechanical changes to adjust to the new api.