-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add getForbiddenFilenames to \OCP\Util and unify filename sanitizing #45151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
Waiting for reviews
php
Pull requests that update Php code
labels
May 2, 2024
susnux
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
May 2, 2024
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
7 times, most recently
from
May 2, 2024 20:31
acff472
to
059efb2
Compare
susnux
added
3. to review
Waiting for reviews
enhancement
and removed
2. developing
Work in progress
bug
labels
May 2, 2024
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
from
May 2, 2024 20:48
059efb2
to
54f89f7
Compare
susnux
requested review from
icewind1991,
blizzz,
nfebe,
a team and
ArtificialOwl
and removed request for
a team
May 2, 2024 21:22
artonge
reviewed
May 7, 2024
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
from
May 7, 2024 12:32
374aed6
to
60838bf
Compare
4 tasks
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
from
July 3, 2024 14:32
74de2ee
to
841d19d
Compare
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
from
July 3, 2024 19:34
841d19d
to
994dc7b
Compare
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
from
July 3, 2024 19:42
994dc7b
to
1968b74
Compare
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
from
July 3, 2024 20:05
1968b74
to
8d6cf37
Compare
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
3 times, most recently
from
July 3, 2024 21:41
e3dc322
to
5e160c0
Compare
…ame validation Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…meValidator Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…lidation Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…izing Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
from
July 5, 2024 11:33
5e160c0
to
a5817ca
Compare
4 tasks
skjnldsv
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Work in progress
enhancement
feedback-requested
php
Pull requests that update Php code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preparations and refactoring for #44963
Summary
\OCP\Util::getForbiddenFilenames()
)OC_Util::isValidFilename
as it was deprecated for a long time, not used anymore and not checking forbidden filenames\OCP\Files\FileInfo::BLACKLIST_FILES_REGEX
as this was not used anywhere (only in the util function but that is also not used anywhere + in the files app, but never enforced on webdav).Todo⚠️ - Needs discussion
.fileinfo
files. So I dropped it, but should be instead enfore it?Checklist