Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(setupcheck): Check several config values to be valid URLs (and more) #45382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(setupcheck): Check several config values to be valid URLs (and more) #45382

wants to merge 1 commit into from
+236 −2

Conversation

nickvergessen
Copy link
Member

TODO

  • Validate that several configs are valid URLs or of hardcoded other format
  • Make sure overwrite.cli.url is within trusted_domains
  • Mark more of those configs as sensitive

Checklist

@nickvergessen
feat(setupcheck): Check several config values to be valid URLs (and m…
38912df 
…ore)

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone May 16, 2024
@nickvergessen nickvergessen self-assigned this May 16, 2024
@nickvergessen nickvergessen mentioned this pull request May 16, 2024
Open
4 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2024
View reviewed changes
apps/settings/lib/SetupChecks/ConfigValidation.php
}

if (filter_var($parts[0], FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
if (!is_numeric($parts[1]) || $parts[1] > 32 || $parts[1] < 1) {

Check notice

Code scanning / Psalm

PossiblyUndefinedArrayOffset Note

Possibly undefined array key $parts[1] on list{0: string, 1?: string}
apps/settings/lib/SetupChecks/ConfigValidation.php
return SetupResult::error($this->l10n->t('Config value %s is not an valid IP address or IP range.', [$configKey]));
}
} elseif (filter_var($parts[0], FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
if (!is_numeric($parts[1]) || $parts[1] > 128 || $parts[1] < 1) {

Check notice

Code scanning / Psalm

PossiblyUndefinedArrayOffset Note

Possibly undefined array key $parts[1] on list{0: string, 1?: string}
@kesselb
Copy link
Contributor

kesselb commented May 17, 2024

Good idea 👍

Some people were confused with the well-known setup check because it stops on the first failure.

I fear this could be confusing here as well if you encounter many issues in the configuration file.

This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@joshtrichards joshtrichards linked an issue Aug 19, 2024 that may be closed by this pull request
[Bug]: occ config:list system does not redact trusted_domains and overwrite.cli.url #45080
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nickvergessen nickvergessen

Labels
2. developing Work in progress enhancement feature: occ feature: settings
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: occ config:list system does not redact trusted_domains and overwrite.cli.url
4 participants
@nickvergessen @kesselb @joshtrichards @skjnldsv