Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename openFileInfo to fileInfo #45963

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Rename openFileInfo to fileInfo #45963

merged 2 commits into from
Jun 19, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jun 19, 2024

And check if openFile is set in the URL before opening a file.

@artonge artonge requested a review from skjnldsv as a code owner June 19, 2024 08:51
@artonge artonge self-assigned this Jun 19, 2024
@skjnldsv skjnldsv requested a review from susnux June 19, 2024 08:51
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jun 19, 2024
@skjnldsv
Copy link
Member

/backport to stable29

@skjnldsv
Copy link
Member

/backport to stable28

@skjnldsv
Copy link
Member

@ShGKme because we talked about this iirc

ShGKme
ShGKme approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💙

In which case do we have no fileid from route and initial state is required? Except the public sharing.

apps/files/src/components/FilesListVirtual.vue Outdated Show resolved Hide resolved
@artonge
Copy link
Contributor Author

artonge commented Jun 19, 2024

In which case do we have no fileid from route and initial state is required? Except the public sharing.

I don't remember, but I think this use case does not exists anymore with F2V.

@artonge
Copy link
Contributor Author

artonge commented Jun 19, 2024

/compile /

artonge and others added 2 commits June 19, 2024 15:38
@artonge
fix(files): Rename openFileInfo to fileInfo
f7c9ac8 
And check if openFile is set in the URL before opening a file.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@nextcloud-command @artonge
chore(assets): Recompile assets
59ea179 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge enabled auto-merge June 19, 2024 14:53
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 19, 2024
@skjnldsv skjnldsv disabled auto-merge June 19, 2024 15:04
@skjnldsv skjnldsv merged commit 18cf61d into master Jun 19, 2024
165 checks passed
@skjnldsv skjnldsv deleted the artonge/fix/openfile branch June 19, 2024 15:04
This was referenced Jun 19, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @skjnldsv @ShGKme @nextcloud-command