Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Document CSRF token endpoint #46761

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

provokateurin
Copy link
Member

Summary

Exposes the endpoint to OpenAPI as it is necessary to receive a token for calling CSRF-protected endpoints.

Checklist

@provokateurin provokateurin added the 3. to review Waiting for reviews label Jul 25, 2024
@provokateurin provokateurin added this to the Nextcloud 30 milestone Jul 25, 2024
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/core/document-csrf-token-endpoint branch from 98a0b04 to 90e108e Compare July 25, 2024 16:04
@susnux susnux added the bug label Jul 25, 2024
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- fix(core): Document CSRF token endpoint 
+ docs(core): Document CSRF token endpoint

@provokateurin
Copy link
Member Author

In general yes, but in this case I think it was a bug in the code because it should have not been ignored :D

@provokateurin provokateurin merged commit a9b77c3 into master Jul 26, 2024
167 checks passed
@provokateurin provokateurin deleted the fix/core/document-csrf-token-endpoint branch July 26, 2024 05:13
@blizzz blizzz mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants