-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Provide default file action for file entry name (on click action) #46768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
changed the title
Fix/files actions
fix(files): Provide default file action for file entry name (on click action)
Jul 25, 2024
/backport to stable29 |
/backport to stable28 |
susnux
force-pushed
the
fix/files-actions
branch
from
July 26, 2024 00:12
cb7155d
to
17493b1
Compare
skjnldsv
reviewed
Jul 26, 2024
skjnldsv
approved these changes
Jul 26, 2024
Yeah, the old legacy link/action was too weird in the end. |
Merged
susnux
force-pushed
the
fix/files-actions
branch
from
July 30, 2024 11:56
17493b1
to
75fda61
Compare
sorbaugh
approved these changes
Jul 30, 2024
susnux
force-pushed
the
fix/files-actions
branch
8 times, most recently
from
July 31, 2024 23:50
7d7ce01
to
739716c
Compare
This fixes non reactive default action text of the name component. Also use download action as default action so that only one place is needed to define how to download a file. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-actions
branch
from
July 31, 2024 23:56
739716c
to
948a64e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two issues with the files actions:
$parent.$refs.something
this is not reactive and leads to situations where the default actions was not correctly injected -> Tooltip was wrongChecklist