Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): wrap initial state into hidden container #46873

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 30, 2024

Summary

Sometimes it's quite annoying during debug that there are tons of elements in the document's root for initial state.

I propose to wrap it in a hidden container.

Before After
image image
image image

TODO

  • Wrap all <input id="initial-state-..." /> into a hidden div container
  • Move it to a new file for reuse

Checklist

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review Waiting for reviews technical debt labels Jul 30, 2024
@ShGKme ShGKme self-assigned this Jul 30, 2024
@ShGKme ShGKme added this to the Nextcloud 30 milestone Jul 30, 2024
@blizzz blizzz mentioned this pull request Jul 30, 2024
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 31, 2024
@AndyScherzinger AndyScherzinger merged commit 5bfe8df into master Aug 1, 2024
168 of 169 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/hide-initial-state-into-container branch August 1, 2024 07:50
@blizzz blizzz mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants