-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sharebymail): improve share email format #46985
Conversation
e750265
to
96b2d57
Compare
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! Very cool that the buttons are rounded now :)
All looks good, only small change I would suggest is to remove the message in gray at the bottom "X shared Y with you. Click the button below to open it." as it seems redundant now :)
Approving to not block
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
eb5bea7
to
879d248
Compare
As discussed:
»
and«
Fix #15680
cc @jancborchardt @nimishavijay @marcoambrosini