fix: Make app menu overflow entries vertically aligned #47034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Aug 5, 2024
AndyScherzinger
approved these changes
Aug 7, 2024
nextcloud-command
requested review from
miaulalala,
nickvergessen,
st3iny,
skjnldsv,
come-nc and
tcitworld
as code owners
|
What happened here? :D Over 100 commits doesn't look right. |
|
@st3iny nope, I did a rebase but GH went nuts, showed the processing changes spinner next to the PR title and now this.... |
|
@susnux sorry for any mess I might have caused. Tryed to warp it up and get it merged. However currently I can't clone the repo or fetch latest changes on an existing checkout, nor do a git pull all of them fail against GH... |
AndyScherzinger
force-pushed
the
fix/app-menu-overflow
branch
from
816c508
to
8b94f3d
Compare
The `name` property expects a `text` and just adds basically a "heading" for the text, so lets instead just utilize the default slot. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AndyScherzinger
force-pushed
the
fix/app-menu-overflow
branch
from
8b9cd54
to
7cef884
Compare
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
nameproperty expects atextand just adds basically a "heading" for the text, so lets instead just utilize the default slot.Checklist