Properly encapsulate require_once for app.php #8372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
nickvergessen
approved these changes
Feb 15, 2018
MorrisJobke
approved these changes
Feb 15, 2018
MorrisJobke
added
4. to release
MorrisJobke
reviewed
Feb 15, 2018
| @@ -133,6 +133,7 @@ public static function loadApps($types = null) { | |||
| * load a single app | |||
| * | |||
| * @param string $app | |||
| * @throws Exception | |||
There was a problem hiding this comment.
This should be added to requireAppFile 😉
There was a problem hiding this comment.
Added an annotation for Error to requireAppFile, but Exception can be thrown by loadApps though self::disable
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Codecov Report
@@ Coverage Diff @@
## master #8372 +/- ##
============================================
- Coverage 51.76% 51.69% -0.07%
Complexity 25395 25395
============================================
Files 1599 1599
Lines 95110 95111 +1
Branches 1376 1376
============================================
- Hits 49232 49166 -66
- Misses 45878 45945 +67
|
This was referenced Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app has an appinfo/app.php file, that includes a variable called $app, this would lead to a type error when calling getAppInfo otherwise.