Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move over to Migrations #131

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Move over to Migrations #131

merged 3 commits into from
Dec 6, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Dec 4, 2018

Fixes #11

@rullzer
Move over to Migrations
1b00287 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the 0.1 🥚 milestone Dec 4, 2018
@rullzer rullzer mentioned this pull request Dec 4, 2018
Closed
@jancborchardt jancborchardt added enhancement New feature or request 3. to review labels Dec 4, 2018
nickvergessen
nickvergessen reviewed Dec 5, 2018
View reviewed changes
lib/Migration/Version000063Date20181204203147.php Outdated
use OCP\Migration\SimpleMigrationStep;
use OCP\Migration\IOutput;

class Version000063Date20181204203147 extends SimpleMigrationStep {
Copy link
Member

@nickvergessen nickvergessen Dec 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version should be 0001 for now 🙈
See nextcloud/server#12275 (comment) for naming pattern

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daita @juliushaertl could you check this out? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to just edit this PR. I have duplo day so limited time today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed

@ArtificialOwl
Copy link
Member

Thanks !

Let's finish to fix the issues with sqlite and merge this one at the end

@ArtificialOwl
fixing boolean and +avatar_version
f08e7f2 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
Copy link
Member

@nickvergessen I don't know if you're the one that wrote the script to generate the Migrations, but I had to fix the default boolean.

@ArtificialOwl ArtificialOwl merged commit f08e7f2 into master Dec 6, 2018
@ArtificialOwl ArtificialOwl deleted the feature/11/migrations branch December 6, 2018 20:42
@nickvergessen
Copy link
Member

I don't know if you're the one that wrote the script to generate the Migrations, but I had to fix the default boolean.

Well please submit a patch:
https://github.com/nextcloud/server/blob/f772b7b4dd408061c8b1151331b9efc6e2e7b96c/core/Command/Db/Migrations/GenerateFromSchemaFileCommand.php#L128-L136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@jancborchardt jancborchardt jancborchardt left review comments

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
0.1 🥚
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @ArtificialOwl @nickvergessen @jancborchardt