Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend implementation #8

Merged
merged 13 commits into from
Oct 26, 2018
Merged

Frontend implementation #8

merged 13 commits into from
Oct 26, 2018

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 10, 2018

This is a first start implementing the apps frontend in vue.js

image

  • Routing structure
  • Views
    • User profile
      • Timeline
      • Followers
      • Following
    • Public page for accounts
      • Timeline
      • Followers
      • Following
  • Components design
    • Timeline
    • TimelineEntry
    • ProfileInfo
  • Use real data in views

@daita Is there already an API endpoint where posts can be fetched/created? Is the social account creating already done using the federated cloud id?

cc @jancborchardt

@jancborchardt
Copy link
Member

Aaalright, nice! :) We should limit the width as on the mockup for readability (keeping the container centered on screen, as if the navigation wasn't there). Otherwise apart from details it looks great! :)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@jancborchardt
Copy link
Member

Getting some Vue errors on compilation:

WARNING in ./src/views/Timeline.vue?vue&type=template&id=e945440a&scoped=true& (./node_modules/vue-loader/lib/loaders/templateLoader.js??vue-loader-options!./node_modules/vue-loader/lib??vue-loader-options!./src/views/Timeline.vue?vue&type=template&id=e945440a&scoped=true&)
Module Warning (from ./node_modules/vue-loader/lib/loaders/templateLoader.js):
(Emitted value instead of an instance of Error) <timeline-entry v-for="entry in timeline">: component lists rendered with v-for should have explicit keys. See https://vuejs.org/guide/list.html#key for more info.
 @ ./src/views/Timeline.vue?vue&type=template&id=e945440a&scoped=true& 1:0-218 1:0-218
 @ ./src/views/Timeline.vue
 @ ./src/router.js
 @ ./src/main.js

WARNING in ./src/views/ProfileTimeline.vue?vue&type=template&id=9c426680&scoped=true& (./node_modules/vue-loader/lib/loaders/templateLoader.js??vue-loader-options!./node_modules/vue-loader/lib??vue-loader-options!./src/views/ProfileTimeline.vue?vue&type=template&id=9c426680&scoped=true&)
Module Warning (from ./node_modules/vue-loader/lib/loaders/templateLoader.js):
(Emitted value instead of an instance of Error) <timeline-entry v-for="entry in timeline">: component lists rendered with v-for should have explicit keys. See https://vuejs.org/guide/list.html#key for more info.
 @ ./src/views/ProfileTimeline.vue?vue&type=template&id=9c426680&scoped=true& 1:0-225 1:0-225
 @ ./src/views/ProfileTimeline.vue
 @ ./src/router.js
 @ ./src/main.js

@jancborchardt
Copy link
Member

App does not show up and the Nextcloud log gives me this:

{"reqId":"QKS58OuqKa7PZuwedOVk","level":3,"time":"2018-10-25T22:34:47+00:00","remoteAddr":"127.0.0.1","user":"jan","app":"PHP","method":"GET","url":"\/nextcloud\/index.php\/apps\/social\/","message":"Trait 'daita\\MySmallPhpTools\\Traits\\TArrayTools' not found at \/home\/jan\/nextcloud\/apps\/social\/lib\/Service\/ActorService.php#48","userAgent":"Mozilla\/5.0 (X11; Ubuntu; Linux x86_64; rv:63.0) Gecko\/20100101 Firefox\/63.0","version":"15.0.0.1"}

@juliusknorr
Copy link
Member Author

App does not show up and the Nextcloud log gives me this:
Trait 'daita\\MySmallPhpTools\\Traits\\TArrayTools

cc @daita Seems composer isn't properly generating the classmap for your library.

Getting some Vue errors on compilation

Can be ignored for now, once we have real data we can properly define a key

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

@jancborchardt The issue was fixed by @daita on master. Feel free to check out the latest results from there.

@jancborchardt jancborchardt added the enhancement New feature or request label Oct 30, 2018
@jancborchardt jancborchardt added this to the First alpha milestone Dec 2, 2018
juliusknorr pushed a commit that referenced this pull request Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants