Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessagesList) - don't add parent messages to the messages list #10296

Merged
merged 4 commits into from Aug 23, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 21, 2023

☑️ Resolves

  • Fix User's and system messages with parent add them as a separate messages out of context #10007
  • User replies:
    • don't add parent messages to the list
    • contain parent message inside, how it naturally comes from server, and use it for <Quote/> component
    • navigate to parent message on click on <Quote/> (fetch if needed, and highlight)
  • System messages message_deleted:
    • don't add parent messages to the list
    • are no longer appear in messages store/list
    • update parent message only if it's in the store/list already
  • System messages reaction and reaction_<...>:
    • update parent message only if it's in the store/list already
  • Minor optimisations of processMessage action and unit tests

🖼️ Screenshots

Fetch limit set to 3. Last 3 messages are:

  • User's reply (to test message 1)
  • System 'message_deleted' (to test message 2)
  • System 'reaction' (to test message 3)
🏚️ Before 🏡 After
image image

🚧 Tasks

  • Replies
    • Works for messages, temporary messages, NewMessage form
  • Deleted messages
  • Reactions
  • Code review
  • Test different usecases

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Aug 21, 2023
@Antreesy Antreesy self-assigned this Aug 21, 2023
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/10007/keep-parent-messages branch from 455d4cf to 20b0e0d Compare August 22, 2023 18:18
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/10007/keep-parent-messages branch from 20b0e0d to 131971f Compare August 22, 2023 19:02
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/10007/keep-parent-messages branch from 131971f to 4ea474d Compare August 22, 2023 19:07
@Antreesy Antreesy marked this pull request as ready for review August 22, 2023 19:09
@nickvergessen nickvergessen merged commit 7851419 into master Aug 23, 2023
20 checks passed
@nickvergessen nickvergessen deleted the fix/10007/keep-parent-messages branch August 23, 2023 10:15
@Antreesy
Copy link
Contributor Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User's and system messages with parent add them as a separate messages out of context
3 participants