-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort by rooms by last activity #1061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
enhancement
feature: api 🛠️
OCS API for conversations, chats and participants
mobile apps
labels
Jul 18, 2018
I would say only last message is relevant?
…On Wed, 18 Jul 2018 at 14:02, Joas Schilling ***@***.***> wrote:
- Based on #1025 <#1025>
Currently activity is:
- A user joins the call
- A chat message is sent
------------------------------
You can view, comment on, or merge this pull request online at:
#1061
Commit Summary
- Add support for backend favorites
- Handle the favorite on the participant object and fix favorite
spelling
- Add favorite handling to the web UI
- Fix unit tests
- Store the timestamp of the last activity in a room and sort by that,
instead of the last ping
File Changes
- *M* appinfo/info.xml
<https://github.com/nextcloud/spreed/pull/1061/files#diff-0> (2)
- *M* appinfo/routes.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-1> (19)
- *M* docs/api-v1.md
<https://github.com/nextcloud/spreed/pull/1061/files#diff-2> (26)
- *M* js/models/roomcollection.js
<https://github.com/nextcloud/spreed/pull/1061/files#diff-3> (9)
- *M* js/views/roomlistview.js
<https://github.com/nextcloud/spreed/pull/1061/files#diff-4> (46)
- *M* lib/AppInfo/Application.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-5> (12)
- *M* lib/Capabilities.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-6> (2)
- *M* lib/Controller/RoomController.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-7> (55)
- *M* lib/Manager.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-8> (9)
- *A* lib/Migration/Version3003Date20180707222130.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-9> (53)
- *A* lib/Migration/Version3003Date20180718112436.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-10> (54)
- *M* lib/Participant.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-11> (30)
- *M* lib/Room.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-12> (29)
- *M* tests/php/CapabilitiesTest.php
<https://github.com/nextcloud/spreed/pull/1061/files#diff-13> (2)
Patch Links:
- https://github.com/nextcloud/spreed/pull/1061.patch
- https://github.com/nextcloud/spreed/pull/1061.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1061>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWsoSkJn6r2_F6fsXkbjMl6OlQqjVeks5uHyPEgaJpZM4VUeC2>
.
|
When someone goes in a room and starts a call, it should also be bumped to the top, because it is relevant information. |
…instead of the last ping Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feature/noid/sort-by-room-activity
branch
from
July 19, 2018 11:51
4ce0a95
to
84b5566
Compare
Rebased and ready to review |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feature/noid/sort-by-room-activity
branch
from
July 19, 2018 15:02
2e60e00
to
ed7d2b2
Compare
Ivansss
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently activity is: