Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate pollsStore to Pinia 🍍 #13249

Merged
merged 3 commits into from
Sep 14, 2024
Merged

fix: migrate pollsStore to Pinia 🍍 #13249

merged 3 commits into from
Sep 14, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 10, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

no visual changes

🚧 Tasks

  • Write tests
  • Migrate to TS (follow-up)
  • Migrate pollService to TS (follow-up)

🏁 Checklist

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 10, 2024
@Antreesy Antreesy self-assigned this Sep 10, 2024
@Antreesy
fix: migrate usePollsStore to Pinia
4208d92 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: minor store refactoring
3456eb6 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy marked this pull request as ready for review September 11, 2024 09:12
DorraJaouad
DorraJaouad approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 🦅, tested ✅

src/stores/__tests__/polls.spec.js Outdated Show resolved Hide resolved
@Antreesy
fix: add tests coverage for polls store
ffb7869 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit dd61c8e into main Sep 14, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/noid/pollstore-to-pinia branch September 14, 2024 12:07
@Antreesy
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client feature: polls 📊 technical debt
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad