Add screensharing extension links to notifications #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=========================================
Coverage 17.31% 17.31%
Complexity 240 240
=========================================
Files 16 16
Lines 1155 1155
=========================================
Hits 200 200
Misses 955 955Continue to review full report at Codecov.
|
|
I'm fine with it, but we could also do: And I guess the same also exists for chrome |
nickvergessen
approved these changes
Mar 16, 2017
marcoambrosini
pushed a commit
that referenced
this pull request
Oct 9, 2019
Build separate entrypoints for each component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements what discussed in #227 (comment) regarding notifications when no screensharing extension installed.