Autocomplete for mentions #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
backport-request
design
enhancement
feature: chat 💬
|
Sorting should be by best match rather than alphabetic. Last chat message is already a good metric for "best match". :) |
|
@danxuliu Can you help copying the UI/UX changes from https://github.com/nextcloud/server/pull/6982/files
|
nickvergessen
commented
Apr 25, 2018
js/views/chatview.js
Outdated
| this._autoCompleteRequestCall.abort(); | ||
| } | ||
| this._autoCompleteRequestCall = $.ajax({ | ||
| url: OC.linkToOCS('apps/spreed/api/v1/chat', 2) + 'dshwd9uv' /* FIXME this.token */ + '/autocomplete', |
There was a problem hiding this comment.
🙈 we don't seem to have access to the room info in this view?
danxuliu
force-pushed
the
feature/noid/chat-autocomplete-suggestions
branch
from
a9133d5
to
679f08f
Compare
|
@nickvergessen For consistency with the Comments app, the author should not be suggested in the autocompletion. Also it seems that matching by display name is case sensitive; it should be case insensitive. |
danxuliu
force-pushed
the
feature/noid/chat-autocomplete-suggestions
branch
from
679f08f
to
79db8da
Compare
|
@nickvergessen Unless I have missed something the UI should be ready. |
|
Ready for review @Ivansss |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
CSS styles were directly copied from "apps/comments/css/autocomplete.scss". JavaScript code in the chat view was slightly simplified from "apps/comments/js/commentstabview.js". Currently mentions are not formatted when a message is being composed; "@" followed by the user name is added to the message so it can be directly sent without further processing. Formatted mentions will be introduced in another commit. Signed-off-by: Joas Schilling <coding@schilljs.com>
The server expects mentions to be in plain text, so the formatted mentions have to be converted to "@" followed by the user name before the message is sent to the server. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
danxuliu
force-pushed
the
feature/noid/chat-autocomplete-suggestions
branch
from
090e87d
to
d8c56b4
Compare
|
I have rebased on master and amended the CSS file to solve the "conflict" with #814 (it was not really a conflict, but the CSS rules were not properly sorted due to the automatic merging). |
Ivansss
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle guests=> Does not work, because they have no unique user id