Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify standalone signaling server about sessions to remove from room. #869

Merged
merged 1 commit into from
May 9, 2018

Conversation

fancycode
Copy link
Member

Btw, that is the expected behaviour when a user is removed? For now I can simply reconnect and will be in the room again.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
@fancycode fancycode added 3. to review backport-request feature: signaling 📶 Internal and external signaling backends labels May 8, 2018
@nickvergessen
Copy link
Member

Btw, that is the expected behaviour when a user is removed? For now I can simply reconnect and will be in the room again.

For a public room? Yes. For a private one? No.

Something like "ban" is missing, yes, but it's also not easy because banning by IP is useless so it would only work for normal users too

@fancycode
Copy link
Member Author

For a public room? Yes. For a private one? No.

Ok, this is the behaviour I'm seeing. Only tested public calls before. In a private room, the user is disconnected and loads the Talk app afterwards. I guess I got a bit confused as there is no feedback to the participant that he got kicked.

So this is ready to review (basically triggers the event to the signaling server, so that can close the connection to the client).

@nickvergessen
Copy link
Member

I guess I got a bit confused as there is no feedback to the participant that he got kicked.

#857

@fancycode
Copy link
Member Author

But isn't #857 about a deleted room and the UI that gets stuck, or do I miss something?

Both doesn't happen here: a user is kicked, and the browser reloads for him, showing the Talk app where he can switch to a different room / create one. But no information that he got kicked.

@fancycode fancycode merged commit 296082f into master May 9, 2018
@fancycode fancycode deleted the standalone-signaling-remove-sessions branch May 9, 2018 08:08
@nickvergessen nickvergessen added this to the 4.0 (Nextcloud 14) milestone May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants