Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): remove pagination of there is just one page #1218

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(files): remove pagination of there is just one page #1218

merged 1 commit into from
Jul 19, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

Fixes #1211

  • remove pagination of there is just one page
  • set spread for the box shadow to 6px
  • remove sticky position

Screenshots

Before After
Peek 2024-07-18 16-041 Peek 2024-07-18 16-04

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jul 18, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jul 18, 2024
@JuliaKirschenheuter
fix(files): remove pagination of there is just one page
3e277c3 
set spread for the box shadow to 6px
remove sticky position

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
enjeck
enjeck approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😎

@juliushaertl juliushaertl merged commit 85c4043 into main Jul 19, 2024
46 checks passed
@juliushaertl juliushaertl deleted the bugfix-1211-adapt-pagination branch July 19, 2024 08:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@enjeck enjeck enjeck approved these changes

@grnd-alt grnd-alt Awaiting requested review from grnd-alt

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews feedback-requested
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table view: Remove pagination of there is just one page and set spread for the box shadow to 6px
3 participants
@JuliaKirschenheuter @juliushaertl @enjeck