add workaround to start videocalls when PIP is disabled #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a dirty workaround for issue #1677 Somehow onUserLeaveHint is executed when the user starts a videocall. If PIP is disabled, the logic inside enterPipMode would finish the activity right after it was started. This workaround suppresses the execution of enterPipMode right after the activity was started. However if a user would press the home button in the first three seconds, the call would continue in background without the ability to recover the UI. To better fix this bug it must be found out why onUserLeaveHint is executed on start (this should not happen!). Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
timkrueger
approved these changes
Nov 15, 2021
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1685-talk.apk |
Lint
SpotBugs (new)
SpotBugs (master)
|
This was referenced Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a dirty workaround for issue #1677
Somehow onUserLeaveHint is executed when the user starts a videocall. If PIP is disabled, the logic inside enterPipMode would finish the activity right after it was started.
This workaround suppresses the execution of enterPipMode right after the activity was started.
However if a user would press the home button in the first three seconds, the call would continue in background without the ability to recover the UI.
To better fix this bug it must be found out why onUserLeaveHint is executed on start (this should not happen!).
Signed-off-by: Marcel Hibbe dev@mhibbe.de