-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnosis screen and add permission checks in settings #3558
Conversation
ecfdc58
to
a69376c
Compare
a69376c
to
e02b395
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one thing to decide would be if the diagnosis option should be hidden for branded clients or if the "create issue" option should be hidden. Just mentioning it since they point to our GH repo.
e02b395
to
a1ef245
Compare
done by hiding "create issue" |
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
a1ef245
to
c7a72aa
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3558-talk.apk |
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x