Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnosis screen and add permission checks in settings #3558

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Jan 5, 2024

🖼️ Screenshots

Diagnose button in settings Diagnose screen Notification permission warning in settings Exported markdown
Screenshot_20240105_160926 geaendert Screenshot_20240105_160942 geaendert Screenshot_20240105_161202 geaendert Screenshot_20240105_161527 geaendert

🚧 TODO

  • database migration

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi force-pushed the feature/noid/addNotificationHintsToSettings branch from ecfdc58 to a69376c Compare January 11, 2024 11:10
@mahibi mahibi added this to the 18.1.0 milestone Jan 11, 2024
@mahibi mahibi self-assigned this Jan 11, 2024
@mahibi mahibi added the 3. to review Waiting for reviews label Jan 11, 2024
@mahibi mahibi force-pushed the feature/noid/addNotificationHintsToSettings branch from a69376c to e02b395 Compare January 11, 2024 12:15
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing to decide would be if the diagnosis option should be hidden for branded clients or if the "create issue" option should be hidden. Just mentioning it since they point to our GH repo.

@mahibi mahibi force-pushed the feature/noid/addNotificationHintsToSettings branch from e02b395 to a1ef245 Compare January 11, 2024 14:23
@mahibi
Copy link
Collaborator Author

mahibi commented Jan 11, 2024

LGTM, one thing to decide would be if the diagnosis option should be hidden for branded clients or if the "create issue" option should be hidden. Just mentioning it since they point to our GH repo.

done by hiding "create issue"

@mahibi mahibi enabled auto-merge January 11, 2024 14:24
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the feature/noid/addNotificationHintsToSettings branch from a1ef245 to c7a72aa Compare January 12, 2024 08:58
@mahibi mahibi merged commit 52d63fb into master Jan 12, 2024
15 of 16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/addNotificationHintsToSettings branch January 12, 2024 09:03
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8383
Errors88

SpotBugs

CategoryBaseNew
Bad practice66
Correctness88
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total139139

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3558-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi changed the title Add diagnose screen and add permission checks in settings Add diagnosis screen and add permission checks in settings Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants