Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave doesn't differentiate between its own changes and external ones #2078

Closed
nawordar opened this issue Aug 18, 2022 · 2 comments
Closed

Comments

@nawordar
Copy link

Steps to reproduce

Many things trigger this problem, but the most reliable way I found is this one:

  1. Add a new tag to a task. Let's call it "test"
  2. After adding it, remove it right away

Expected behaviour

The tag is removed successfully.

Actual behaviour

A yellow warning signs shows up with a message "Could not update the task because it was changed on the server. Please click to refresh it, local changes will be discarded."

Server configuration

I have my instance running through a Docker image: docker.io/nextcloud:24-apache

Operating system: Arch Linux

Web server: Apache

Database: PostgreSQL (docker.io/postgres:14-alpine)

PHP version: 8.0.22

Nextcloud version: 24.0.4

Tasks version: 0.14.4

Updated from an older Nextcloud or fresh install: I was updating both Nextcloud and Tasks

Signing status: ?

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Aug 18, 2022

This is very likely a configuration issue, either on the server side or in your browser. The Etag of the request is probably changed somewhere on the way and then the Tasks app has no chance of figuring out if it might overwrite a change that happened on the server or not. See #2077 for example where a browser plugin stripped of the correct Etag.

Also, if the task was indeed changed on the server (which is not clear from your description), then showing a conflict warning is the only way we can currently handle this.

@nawordar
Copy link
Author

nawordar commented Aug 18, 2022

This is very likely a configuration issue, either on the server side or in your browser. The Etag of the request is probably changed somewhere on the way and then the Tasks app has no chance of figuring out if it might overwrite a change that happened on the server or not. See #2077 for example where a browser plugin stripped of the correct Etag.

Also, if the task was indeed changed on the server (which is not clear from your description), then showing a conflict warning is the only way we can currently handle this.

This was exactly my problem (clearing ETags in ClearURLs add-on). Sorry for not filling in the whole template, I was convinced that this is a problem with Tasks itself. Will do the next time. Thank you for taking the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants