fix: ctrl+backspace in list item on firefox #5962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested changes
Jun 27, 2024
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
bugfix/ctrl-backspace-in-listitem-on-firefox
branch
from
e11a7ea
to
3ec4e80
Compare
|
Thanks for checking that. Let me put some references here as well: Was bumped in tiptap upstream for the upcoming 2.5.0 release with ueberdosis/tiptap@747985b |
|
@luka-nextcloud @max-nextcloud Any oppinion on having direct prosemirror dependencies again in our package.json? I feel this could cause issues in the future if tiptap ships another version. Shall we just wait for the upstream update? Or merge and revert fixed in upstream? |
|
I think if this issue is not urgent, we'd better wait for the new tiptap release. |
|
Left a comment about this in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The issue came from old version of package
prosemirror-view. It triggered "Enter" key from wrong detection logic. This issue was fixed on newprosemirror-viewrelease.🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)