Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Also commit css files during build #6056

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

juliusknorr
Copy link
Member

📝 Summary

When extracting css files in #6026 we missed that those would also need to be committed to the repo as text is a shipped app.

Otherwise cloning text will not be enough to run it.

@mejo- This could also explain some failures in collectives as @enjeck has seen this in tables

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jul 17, 2024
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone Jul 17, 2024
@juliusknorr juliusknorr merged commit 4c97672 into main Jul 17, 2024
61 of 64 checks passed
@juliusknorr juliusknorr deleted the ci/also-commit-css branch July 17, 2024 11:41
@max-nextcloud
Copy link
Collaborator

This breaks the reuse compliance check right now. See https://github.com/nextcloud/text/actions/runs/9990903976/job/27612952021 for an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants