-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Delete inactive sessions in one query #4339
Conversation
Passing run #10776 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
6488bbf
to
cf3109e
Compare
Sqlite somehow fails, but only on CI 🙈
/home/runner/actions-runner/_work/text/text/apps/text/tests/unit/Db/SessionMapperTest.php:97 |
ad9b0ca
to
6817892
Compare
e81d694
to
163b07a
Compare
Let me split this to have only the query change as a backportable fix, as mentioned above the index could be considered a separate enhancement |
163b07a
to
09013d7
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
09013d7
to
85ef18d
Compare
/backport to stable27 |
/backport to stable26 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Fixes #4218
Delete inactive sessions without steps in one query as the oracle limit is only about 1000 expressions. Using one query also has the benefit to avoid deadlock scenarios as the query would lock the rows directly.
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)