Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use simple query and chunk in PHP to delete inactive sessions #4549

Merged
merged 1 commit into from Jul 19, 2023
Merged

fix: Use simple query and chunk in PHP to delete inactive sessions #4549

merged 1 commit into from Jul 19, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jul 19, 2023 •
edited

reverts #4339 and #4539 except for the added tests and moves to plain PHP chunking to avoid issues with MySQL 8

Easiest to review in split mode https://github.com/nextcloud/text/pull/4549/files?diff=split

馃弫 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Jul 19, 2023 •
edited

1 failed and 1 flaky tests on run #11169 鈫楋笌

1 148 2 0 Flakiness 1
鈿狅笍 You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix: Use simple query and chunk in PHP to delete inactive sessions
Project: Text Commit: 0f8e4419d6
Status: Failed Duration: 20:07 馃挕
Started: Jul 19, 2023 1:26 PM Ended: Jul 19, 2023 1:46 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl changed the title bugfix/noid/mysql8 fix: Use simple query and chunk in PHP to delete inactive sessions Jul 19, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Jul 19, 2023
@juliushaertl
Copy link
Member Author

/backport to stable27

@juliushaertl
Copy link
Member Author

/backport to stable26

@juliushaertl
Copy link
Member Author

Cherry-picked to #4548 to validate the tests passing also on CI for MySQL 8

@juliushaertl juliushaertl marked this pull request as ready for review July 19, 2023 12:40
mejo-
mejo- requested changes Jul 19, 2023
View reviewed changes
lib/Db/SessionMapper.php Outdated Show resolved Hide resolved
@juliushaertl
fix: Use simple query and chunk in PHP
0f8e441 
reverts #4339 and #4539 except for the added tests and moves to plain
PHP chunking to avoid issues with MySQL 8

Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
@juliushaertl juliushaertl requested a review from mejo- July 19, 2023 13:09
@juliushaertl
Copy link
Member Author

Failure known and unreated (fixed with #4550)

@juliushaertl juliushaertl merged commit c5dfd46 into main Jul 19, 2023
31 of 35 checks passed
@juliushaertl juliushaertl deleted the bugfix/noid/mysql8 branch July 19, 2023 13:51
This was referenced Jul 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@mejo- mejo- mejo- approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review bug Something isn't working high regression
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juliushaertl @nickvergessen @mejo-