Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix: Use simple query and chunk in PHP to delete inactive sessions #4552

Merged
merged 1 commit into from Jul 19, 2023
Merged

[stable26] fix: Use simple query and chunk in PHP to delete inactive sessions #4552

merged 1 commit into from Jul 19, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #4549

@juliushaertl @backportbot-nextcloud
fix: Use simple query and chunk in PHP
2fb6087 
reverts #4339 and #4539 except for the added tests and moves to plain
PHP chunking to avoid issues with MySQL 8

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working high regression labels Jul 19, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.4 milestone Jul 19, 2023
@cypress
Copy link

cypress bot commented Jul 19, 2023

1 flaky tests on run #11175 ↗︎

0 148 2 0 Flakiness 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

[stable26] fix: Use simple query and chunk in PHP to delete inactive sessions
Project: Text Commit: 2fb60874fc
Status: Passed Duration: 21:22 💡
Started: Jul 19, 2023 2:02 PM Ended: Jul 19, 2023 2:24 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl merged commit 504248a into stable26 Jul 19, 2023
36 of 37 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/4549/stable26 branch July 19, 2023 14:38
@blizzz blizzz mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
bug Something isn't working high regression
Projects
None yet
Milestone
Nextcloud 26.0.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mejo- @juliushaertl