Feature/add sipgate sms support #482
Conversation
rotdrop
force-pushed
the
feature/add-sipgate-sms-support
branch
from
56c235d
to
2bb10d0
Compare
|
I known, #454, still just for the record ... |
rotdrop
force-pushed
the
feature/add-sipgate-sms-support
branch
from
2bb10d0
to
c16146b
Compare
lib/Service/SetupService.php
Outdated
| @@ -91,7 +91,7 @@ public function startSetup(IUser $user, string $gatewayName, string $identifier) | |||
| try { | |||
| $gateway->send($user, $identifier, "$verificationNumber is your Nextcloud verification code."); | |||
| } catch (SmsTransmissionException $ex) { | |||
| throw new VerificationTransmissionException('could not send verification code'); | |||
| throw new VerificationTransmissionException('could not send verification code', $ex->getCode(), $ex); | |||
There was a problem hiding this comment.
On what place the app catch the 2th and 3th argument?
There was a problem hiding this comment.
The log-viewer will display a hierarchy of exception. This is handy for debugging. Otherwise you just see the top-level exception which provides zero information on what was going wrong.
There was a problem hiding this comment.
Create integration tests
Maybe, will be a good time to implement integration tests mocking HTTP request to the gateways.
This is a good package to do this: https://packagist.org/packages/donatj/mock-webserver
Was easy going. Most difficult thing was to figure out the necessary ACL for the access-token at the sipgate-site (sessions:sms:write). Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
rotdrop
force-pushed
the
feature/add-sipgate-sms-support
branch
from
c16146b
to
7f1e999
Compare
|
I think that you created this branch over branch of PR #481 |
Yes; I already stated this as reply to your comment and also rebased to the master branch. |
|
@rotdrop can you put documentation to this on |
No description provided.