Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support https://gitlab.com/morph027/python-signal-cli-rest-api ... #578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rotdrop
Copy link
Contributor

@rotdrop rotdrop commented Jun 19, 2023

... in addition to the deprectated https://gitlab.com/morph027/signal-cli-dbus-rest-api.

As of now that package has been deprecated:

https://gitlab.com/morph027/python-signal-cli-rest-api

But it still works in principle.

I will soon start to work on a version which supports signal-cli's native JSON RPC HTTP endpoint which has been introduced in

signal-cli 0.11.5+

…ition to the deprectated https://gitlab.com/morph027/signal-cli-dbus-rest-api.

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
@ostasevych
Copy link

Please, consider adding support for https://github.com/bbernhard/signal-cli-rest-api/
Here there are experiments with styled messages.

@rotdrop
Copy link
Contributor Author

rotdrop commented Sep 24, 2023

Please, consider adding support for https://github.com/bbernhard/signal-cli-rest-api/ Here there are experiments with styled messages.

Where is "here"?

IMHO, it should still work with https://gitlab.com/morph027/python-signal-cli-rest-api

Doesn't it then also cover this bbernhard things?

@ostasevych
Copy link

Please, consider adding support for https://github.com/bbernhard/signal-cli-rest-api/ Here there are experiments with styled messages.

Where is "here"?
Sorry, for the ambiguity. I mean, bernhard is working on bringing styles to the Signal CLI REST API (bold, italic, strikethrough, monospace are already working).

IMHO, it should still work with https://gitlab.com/morph027/python-signal-cli-rest-api

Doesn't it then also cover this bbernhard things?

That was my question, actually. I should test it.

By now, I have modified the Gateway.php by replacing v1/send with v2/send. Do you think it may be placed in upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants