update to php-saml 3.0.0 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schiessle
force-pushed
the
upgrade-saml-lib
branch
from
ce401e2
to
6b8bebc
Compare
|
@rullzer I updated the saml_php lib to 3.0.0dev to get rid of the mcrypt dependency and everything seems to work. I'm not really happy with creating a fake root to build the correct base url, but I couldn't find a better way: 6b8bebc#diff-0e033fd8797499a87a6bf2ffccef5c3cR31 Btw, I'm surprised that the new version of the lib is so much smaller. Hope we don't miss any functionality here. |
schiessle
force-pushed
the
upgrade-saml-lib
branch
from
6b8bebc
to
dc6a44d
Compare
|
@schiessle it seems you didn't add all the new files? |
schiessle
force-pushed
the
upgrade-saml-lib
branch
from
dc6a44d
to
2a728e1
Compare
|
@rullzer ok, now it looks better. 😉 |
schiessle
force-pushed
the
upgrade-saml-lib
branch
from
2a728e1
to
3986062
Compare
schiessle
force-pushed
the
upgrade-saml-lib
branch
2 times, most recently
from
6c1ad65
to
56d4ce9
Compare
|
@rullzer now with php-saml 3.0.0 stable! 🎉 |
|
@rullzer all tests passed. Maybe you want to have a look and do a small test and then let's get this in, I would say |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
schiessle
force-pushed
the
upgrade-saml-lib
branch
from
56d4ce9
to
7c52695
Compare
* The base route now has a function as well so it is not just some empty route * We now actually have an error page Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
approved these changes
Oct 11, 2018
|
After this is in I'll enable dependabot so we get automatic upgrades |
|
ok... so let's do it 😄 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get rid of the mcrypt dependency. Seems we are still running in this error: SAML-Toolkits/php-saml#249 ... But let's try to find out more