Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard 1 #34

Merged
merged 3 commits into from
Sep 24, 2016
Merged

Keyboard 1 #34

merged 3 commits into from
Sep 24, 2016

Conversation

WaaromZoMoeilijk
Copy link
Member

#25

Ezra added 2 commits September 19, 2016 10:04
keyboard fix
9724234
removed keyboard settings
2e3900b 
moved over to beginning of nextcloud_install
@enoch85
Copy link
Member

enoch85 commented Sep 23, 2016

Thanks!

Please move this to AFTER all the tests on line 126

@WaaromZoMoeilijk
Copy link
Member Author

Done

@enoch85 enoch85 merged commit a0d017b into master Sep 24, 2016
@enoch85
Copy link
Member

enoch85 commented Sep 24, 2016

👍

@enoch85 enoch85 deleted the keyboard-1 branch September 24, 2016 12:43
enoch85
enoch85 reviewed Sep 26, 2016
View reviewed changes
Copy link
Member

@enoch85 enoch85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work, the keyboard layout script should stay in startup-script.sh and also be added to the installation script.

@enoch85 enoch85 mentioned this pull request Sep 26, 2016
Merged
@WaaromZoMoeilijk
Copy link
Member Author

How so? Because of generating locales or something?

@enoch85
Copy link
Member

enoch85 commented Sep 28, 2016

This is fixed now anyway; e85dc27

@flostyen flostyen mentioned this pull request Apr 4, 2018
Closed
@sirmauri2 sirmauri2 mentioned this pull request May 14, 2019
Closed
@dbolton dbolton mentioned this pull request Dec 31, 2019
Closed
@RKlarmann RKlarmann mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enoch85 enoch85 enoch85 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaaromZoMoeilijk @enoch85