Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Light/dark/system theme #119

Closed
DecaTec opened this issue Apr 24, 2017 · 4 comments
Closed

Settings: Light/dark/system theme #119

DecaTec opened this issue Apr 24, 2017 · 4 comments

Comments

@DecaTec
Copy link
Collaborator

DecaTec commented Apr 24, 2017

Let the user choose the app's theme in the settings: Light/dark/system

@DecaTec DecaTec added the design label Apr 24, 2017
@SunboX
Copy link
Member

SunboX commented Apr 24, 2017

This is also related to issue comment #18 (comment)

@DecaTec
Copy link
Collaborator Author

DecaTec commented May 1, 2017

#148

Theme can now be switched, but the app needs to be restarted for the settings to take effect.
This settings is saved in the roaming settings of the app.

It's a little more complex to switch themes during runtime. http://stackoverflow.com/questions/34554871/changing-theme-in-windows-10-uwp-app-programmatically

I don't know if it's worth the effort. What do you think?

@DecaTec DecaTec closed this as completed May 1, 2017
@DecaTec DecaTec added this to the Nextcloud App 1.1.0 milestone May 1, 2017
@SunboX
Copy link
Member

SunboX commented Jun 1, 2017

I've changed it, because setting it in the App's constructor crashed the share pane view. Now the theming of the message boxes and the kayboard won't change. But I think this is a minor issue. I will try one more thing, don't know if it works.

Also, the app must not be restarted now.

@SunboX
Copy link
Member

SunboX commented Jun 1, 2017

I found a better way to dynamicall ychange the theme: https://liftcodeplay.com/2015/08/24/themeresource-dark-and-light-themes-in-windows-10/

I will implement this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants