Updating the default SKU for Azure Batch #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All crashed |
|
Marked as draft 😄 Discussing with Venkat how we can avoid having the same image deprecation issue again. Thinking of implementing a pre-flight check for confirming that the specified image exists. |
abhi18av
force-pushed
the
abhinav/azure-default-sku
branch
from
859008a
to
bde6df0
Compare
|
@pditommaso , I've opened up this PR for a review so that this patches the current default settings. I will follow up with another PR to introduce a pre-flight check to see if the image specified exists or has been retired, essentially the |
pditommaso
reviewed
May 12, 2022
|
Finally!!!
|
pditommaso
approved these changes
May 13, 2022
|
Nice job |
pditommaso
pushed a commit
that referenced
this pull request
May 15, 2022
This commit update the default SKU used by Batch to `batch.node.ubuntu 20.04` in place of `batch.node.centos 8`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the deprecation of CentOS-8 Azure/Batch#119 , the defaults for a Nextflow pool have become a bit problematic.
From experience with some clients the straight-forward solution seems to be to move to
Ubuntubased base image rather thanCentOS 7.8and therefore I've gone ahead and changed those settings.Happy to accommodate any feedback 😊