Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreThenFail error strategy #4686

Merged
merged 17 commits into from
Jun 17, 2024
Merged

Conversation

bentsherman
Copy link
Member

Close #4446

Test example:

process foo {
  errorStrategy 'ignoreThenFail'

  input:
  val id

  script:
  """
  test $id -ne 4
  """
}

workflow {
  foo( Channel.of(1..10) )
}

This pipeline will ignore the failed task but then return a non-zero exit code.

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit a7f01c2
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/667084f98a91f30008990f04
😎 Deploy Preview https://deploy-preview-4686--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bentsherman and others added 2 commits January 30, 2024 21:14
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are needed

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested a review from a team as a code owner April 3, 2024 14:39
@adamrtalbot
Copy link
Collaborator

Hey everyone, can I restart this one a bit? It would be a very useful feature!

@pditommaso
Copy link
Member

pditommaso commented Jun 12, 2024

The problem with this is that ignoreThenFail is longer than 10 characters and will not fit the Platform schema

@bentsherman
Copy link
Member Author

ignoreFail ? 😆

unfortunately the shorter one is not as clear

@pditommaso
Copy link
Member

Was thinking a couple of other implementation alternatives:

  1. use ignoreThenFail but map it to IGNORE enum value and tracking the fail flag independently
  2. instead of introducing new errorStrategy value, define it as an executor or nextflow scope setting

pditommaso and others added 10 commits June 14, 2024 17:40
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
…egy-v3 [ci fast]

4446 ignore then fail strategy v3
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman
Copy link
Member Author

I will review the docs and then it should be good to go

@pditommaso pditommaso merged commit 172edc3 into master Jun 17, 2024
22 checks passed
@pditommaso pditommaso deleted the 4446-ignore-then-fail-strategy branch June 17, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defer error exit status to end of pipeline run
4 participants