Drop GraalJS in favour of Commonmark Java #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Is there any timeframe for finishing this? Asking due to scicloj/wolframite#56 ... Thank you! |
We're doing some progress, but there's not really a timeframe yet. For the moment you might use the workaround mentioned in nextjournal/clerk#642 (comment) (i.e. use #24 as dependency from github). |
|
Ok, thank you! |
via generative testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the implementation for when using this library from the JVM from markdown-it to commonmark-java. We use generative testing to compare both implementations return the same markup.
This comes with an approximate speedup of 10x and fixes #23.