Entity onLoad container

[Mikulas]

Updates #131

[Mikulas]

What it comes down to is IdentityMap::createEntity() calling attach before data is filled

$entity = $this->entityReflections[$entityClass]->newInstanceWithoutConstructor();
$this->repository->attach($entity);
$entity->fireEvent('onLoad', [$data]);

swapping those would not work (onLoad requires metadata set in attach) and also would break back compatibility with onLoad.

I propose adding new event as it's least invasive method and least likely to break anything.

Another solution might be setting metadata via different mechanism than attach. That would also be good for consistency, as setting metadata via attach is only used for entities loaded from storage, new entities have metadata set in constructor (and setting metadata again in attach is redundant).

Are entity events supposed to be overwritten? Either way, the on* methods should list all entity states in which they might be called. I would be happy to send a pr for that.

btw I'm pretty sure there is currently no way to tell what state an entity is in onAttach; an obvious way would be isPersisted(), but that always returns FALSE as id was not yet populated from $data.

[hrach]

Let's discuss it on Telegram!

[Mikulas]

solved: replaced onAttach with onCreate+onLoad