Loading annotation from traits too #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@namo-R Hi, this seems great! Could you please add some test? Maybe just move some already present properties to trait. Also, you may fix the commiter email to match your GitHub profile, if that's you :) |
namo-R
force-pushed
the
load_annotation_from_traits_in_entity
branch
from
2638af0
to
2c70212
Compare
Test for loading trait annotation - created column
namo-R
force-pushed
the
load_annotation_from_traits_in_entity
branch
from
2c70212
to
8fbdb0a
Compare
|
Edited version - have to change because master using classPropertiesCache property. Test added, looks good ;) |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just idea to load annotation for Entity from traits too. Example can be using TimestatemableTrait with
created...orupdate...columns, next can becancelled...etc...First load trait, then entity class for overrides. Methods are loaded from original class with
use ***trait.