Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas version #144

Closed
rneher opened this issue Jun 29, 2018 · 5 comments
Closed

pandas version #144

rneher opened this issue Jun 29, 2018 · 5 comments

Comments

@rneher
Copy link
Member

rneher commented Jun 29, 2018

why do we restrict pandas version to <0.18 (9d1b078). 0.17 is >2y old and the current stable version is 0.23. any known incompatibilities @trvrb @tsibley

@tsibley
Copy link
Member

tsibley commented Jun 29, 2018

pandas release notes indicate 0.18 had breaking changes, and I did not audit 0.18's changes, or the breaking changes of even newer releases, against augur's usage of pandas. This may be me being over-conservative. It would be less conservative, but still reasonable, to set minimums that are known good and accept the possibility of breakage from new versions we haven't tried.

@rneher
Copy link
Member Author

rneher commented Jun 29, 2018

on various systems I had 0.19, 0.20, 0.21 installed. haven't run into any problems. I think minimum req are fine. If we are incompatible with latest numpy, scipy, pandas, we better find out about it sooner rather than later.

@tsibley
Copy link
Member

tsibley commented Jun 29, 2018

Nod. My previous flurry of changes to deps were all based around the previous requirements.txt files that were kept manually pinned to exact versions. This change will be a further departure from those, but I think that's ok. @trvrb?

@trvrb
Copy link
Member

trvrb commented Jun 30, 2018

I would say to upgrade pandas version across the board. Keep it the same for fauna/requirements.txt, augur/requirement.txt and augur/setup.py. And quickly confirm nothing breaking with upgrades. Would be nice to keep dependency versions consistent across components. Certainly makes pip installs easier.

@rneher
Copy link
Member Author

rneher commented Jul 5, 2018

I removed the upper bound in augur. we only use it to read csv....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants