Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rates and traits confidence v2 #232

Merged
merged 4 commits into from Oct 28, 2018
Merged

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Oct 22, 2018

This is a more-or-less direct rebase of PR #213. It does three things:

  1. Implements a --sampling-bias-correction flag in augur traits to add uncertainty to ancestral trait reconstruction.
  2. Implements a --clock-std-dev flag in augur refine to allow inputting of standard deviation of "fixed" clock rate.
  3. Adds both these options to the test builds.
  4. Upgrades TreeTime to version 0.5.1.

@rneher: My testing is showing no effect from the --sampling-bias-correction flag. I tested and it does modify tt.gtr.mu correctly. However, this seems to have no impact on resulting reconstructions. Can you take a look at this?

@trvrb trvrb mentioned this pull request Oct 22, 2018
@rneher
Copy link
Member

rneher commented Oct 22, 2018

For me it does have an impact on the reconstructions -- the higher the value the higher the entropy of the trait reconstruction. What exactly are you comparing?

@trvrb
Copy link
Member Author

trvrb commented Oct 28, 2018

@rneher ---

I see now. I was somehow expecting more of an impact. In the standard Zika build going from --sampling-bias-correction of 1 to 3 takes the root of the tree from 48% Brazil to 43% Brazil.

I suppose that this is due in part to a sparse migration matrix so that adjusting rate only does not have a huge smoothing impact. Does this make sense?

@trvrb
Copy link
Member Author

trvrb commented Oct 28, 2018

I'm going to merge this now and we can continue to improve this aspect. Everything else is working great.

@trvrb trvrb merged commit f41137e into master Oct 28, 2018
@trvrb trvrb deleted the rates-and-traits-confidence-v2 branch October 28, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants